Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Include server action transaction in next tracing #14048

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

chargome
Copy link
Member

Stop escaping Next.js tracing for server action instrumentation.

When using withServerActionInstrumentation the trace will look like this now:

Screenshot 2024-10-22 at 10 03 27

@chargome chargome requested a review from lforst October 22, 2024 08:26
@chargome chargome self-assigned this Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.73 KB added added
@sentry/browser - with treeshaking flags 21.53 KB added added
@sentry/browser (incl. Tracing) 35.12 KB added added
@sentry/browser (incl. Tracing, Replay) 71.86 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.26 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 76.21 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 88.99 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.82 KB added added
@sentry/browser (incl. metrics) 27 KB added added
@sentry/browser (incl. Feedback) 39.87 KB added added
@sentry/browser (incl. sendFeedback) 27.38 KB added added
@sentry/browser (incl. FeedbackAsync) 32.17 KB added added
@sentry/react 25.49 KB added added
@sentry/react (incl. Tracing) 38.09 KB added added
@sentry/vue 26.91 KB added added
@sentry/vue (incl. Tracing) 37.02 KB added added
@sentry/svelte 22.87 KB added added
CDN Bundle 24.11 KB added added
CDN Bundle (incl. Tracing) 36.96 KB added added
CDN Bundle (incl. Tracing, Replay) 71.65 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.99 KB added added
CDN Bundle - uncompressed 70.7 KB added added
CDN Bundle (incl. Tracing) - uncompressed 109.73 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.24 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.46 KB added added
@sentry/nextjs (client) 38.17 KB added added
@sentry/sveltekit (client) 35.74 KB added added
@sentry/node 124.96 KB added added
@sentry/node - without tracing 94.01 KB added added
@sentry/aws-serverless 103.62 KB added added

Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, pls don't hate me but would you mind extending the e2e tests a bit to assert that there is now a hierarchy?

Copy link

codecov bot commented Oct 22, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
234 1 233 12
View the top 1 failed tests by shortest run time
edge-route.test.ts Faulty edge routes
Stack Traces | 0.114s run time
edge-route.test.ts:26:5 Faulty edge routes

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@chargome chargome force-pushed the cg/next-otel-server-actions branch from ddcaf0d to b3b89ae Compare October 23, 2024 08:01
@chargome chargome merged commit dd57025 into lforst-nextjs-otel Oct 23, 2024
108 of 111 checks passed
@chargome chargome deleted the cg/next-otel-server-actions branch October 23, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants