Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Enable nextjs otel spans pages router #13960

Merged
merged 15 commits into from
Oct 17, 2024

Conversation

chargome
Copy link
Member

enables otel instrumentation for data fetchers in pages router

Copy link
Contributor

github-actions bot commented Oct 11, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.73 KB added added
@sentry/browser - with treeshaking flags 21.53 KB added added
@sentry/browser (incl. Tracing) 35.12 KB added added
@sentry/browser (incl. Tracing, Replay) 71.83 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.23 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 76.19 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 88.97 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.8 KB added added
@sentry/browser (incl. metrics) 27 KB added added
@sentry/browser (incl. Feedback) 39.87 KB added added
@sentry/browser (incl. sendFeedback) 27.38 KB added added
@sentry/browser (incl. FeedbackAsync) 32.17 KB added added
@sentry/react 25.49 KB added added
@sentry/react (incl. Tracing) 38.09 KB added added
@sentry/vue 26.91 KB added added
@sentry/vue (incl. Tracing) 37.02 KB added added
@sentry/svelte 22.87 KB added added
CDN Bundle 24.11 KB added added
CDN Bundle (incl. Tracing) 36.96 KB added added
CDN Bundle (incl. Tracing, Replay) 71.62 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.96 KB added added
CDN Bundle - uncompressed 70.7 KB added added
CDN Bundle (incl. Tracing) - uncompressed 109.73 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.17 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.38 KB added added
⛔️ @sentry/nextjs (client) (max: 38.09 KB) 38.17 KB added added
@sentry/sveltekit (client) 35.74 KB added added
@sentry/node 124.95 KB added added
@sentry/node - without tracing 94.01 KB added added
@sentry/aws-serverless 103.61 KB added added

Copy link

codecov bot commented Oct 11, 2024

❌ 5 Tests Failed:

Tests completed Failed Passed Skipped
233 5 228 11
View the top 3 failed tests by shortest run time
server/getServerSideProps.test.ts Should report an error event for errors thrown in getServerSideProps
Stack Traces | 30s run time
getServerSideProps.test.ts:4:5 Should report an error event for errors thrown in getServerSideProps
server/getServerSideProps.test.ts Should report an error event for errors thrown in getServerSideProps in pages with custom page extensions
Stack Traces | 30s run time
getServerSideProps.test.ts:89:5 Should report an error event for errors thrown in getServerSideProps in pages with custom page extensions
isomorphic/getInitialProps.test.ts should propagate serverside `getInitialProps` trace to client
Stack Traces | 30s run time
getInitialProps.test.ts:4:5 should propagate serverside `getInitialProps` trace to client

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@chargome chargome self-assigned this Oct 14, 2024
@chargome chargome force-pushed the cg/next-js-otel-datafetchers branch from b6052e2 to f14fc1e Compare October 16, 2024 10:00
@chargome chargome force-pushed the cg/next-js-otel-datafetchers branch from f14fc1e to 84d101b Compare October 16, 2024 10:24
@chargome chargome requested a review from lforst October 17, 2024 10:44
@chargome chargome merged commit 74b68c7 into lforst-nextjs-otel Oct 17, 2024
111 of 114 checks passed
@chargome chargome deleted the cg/next-js-otel-datafetchers branch October 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants