-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): .set
the sentry-trace
header instead of .append
ing in fetch instrumentation
#13907
Conversation
…n fetch instrumentation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still curious how we'd attach headers multiple times but I think the change is fine.
I guess as long as we don't find out why this happene(d) testing against would be a bit artificial
I think I know a way this can happen. Basically, if you re-use request objects. I'll try to come up with tests. |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
…n fetch instrumentation (#13907)
…n fetch instrumentation (#13907)
Fixes #13870
Fixes #12350
Fixes issues where persistence of the options object passed to
fetch()
would cause the options object, or rather the attachedsentry-trace
andbaggage
headers to indefinitely grow in size.