-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wasm): Integration wasm uncaught WebAssembly.Exception (#13787) #13854
fix(wasm): Integration wasm uncaught WebAssembly.Exception (#13787) #13854
Conversation
Thanks for adding this PR 🙌 |
…mbly.Exception-13787
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@trzeciak these tests fail on Node 20 as apparently there is no exception.message – any idea if there was dropped support? Could not find anything |
@chargome I'm not entirely sure what you mean, but I'm not a JavaScript developer, just a C++ developer, and these changes are specifically to support C++ exceptions compiled to wasm and caught by JavaScript (it's a bit complicated 🙈). |
Add support for wasm WebAssembly.Exception (uncaught exception in emscripten).
References