-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node): Add amqplibIntegration #13714
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share some examples traces with this instrumentation active?
Let's also make sure that the spans generated from this instrumentation show up in the Queues Module in Sentry.
You can read more about the requirements for the queue module here: https://docs.sentry.io/platforms/javascript/guides/node/tracing/instrumentation/custom-instrumentation/queues-module/
dev-packages/node-integration-tests/suites/tracing/amqplib/package.json
Outdated
Show resolved
Hide resolved
dev-packages/node-integration-tests/suites/tracing/amqplib/setup.ts
Outdated
Show resolved
Hide resolved
dev-packages/node-integration-tests/suites/tracing/amqplib/package.json
Outdated
Show resolved
Hide resolved
dev-packages/node-integration-tests/suites/tracing/amqplib/yarn.lock
Outdated
Show resolved
Hide resolved
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
dev-packages/node-integration-tests/suites/tracing/amqplib/init.ts
Outdated
Show resolved
Hide resolved
dev-packages/node-integration-tests/suites/tracing/amqplib/scenario-message.ts
Outdated
Show resolved
Hide resolved
dev-packages/node-integration-tests/suites/tracing/amqplib/test.ts
Outdated
Show resolved
Hide resolved
@obecny I changed the title to match our conventions - we typically make the scope of the PR title be the main package that is being updated (in this case, |
thank you :) |
![]() |
resolves #13312
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint
) & (yarn test
).