fix(browser): check supportedEntryTypes before caling the function #13541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ran into this today. Crashing on older signage displays (Tizen 4 and WebOS 4), which uses Chrome 56 and 53. We have around 200 of those devices running our software. |
AbhiPrasad
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
thanks @odanado for the PR!
Comparing https://docs.sentry.io/platforms/javascript/troubleshooting/supported-browsers/ and the support for supportedEntryTypes in https://caniuse.com/mdn-api_performanceobserver_supportedentrytypes_static we need to add this check.
AbhiPrasad
added a commit
that referenced
this pull request
Sep 9, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13541 Co-authored-by: AbhiPrasad <[email protected]>
|
This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.30.0 - thanks for contributing @odanado! |
|
Thank you for a quick response! |
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PerformanceObserveris available on iOS 11 and later, butthe
supportedEntryTypesmethod is available on iOS 13 and later.ref: https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver
Therefore, a runtime error will occur if we use Sentry on iOS 11 or iOS 12.