Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump @actions/artifact from 1x to 2.x #13503

Merged
merged 2 commits into from
Nov 18, 2024
Merged

ci: Bump @actions/artifact from 1x to 2.x #13503

merged 2 commits into from
Nov 18, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 28, 2024

v1 of this is deprecated, which you can see in each CI run on develop as of now. Updating this should fix the deprecation.

This should not break stuff for us: https://www.npmjs.com/package/@actions/artifact#v2---whats-new

@mydea mydea requested review from Lms24 and andreiborza August 28, 2024 12:45
@mydea mydea self-assigned this Aug 28, 2024
@mydea mydea enabled auto-merge (squash) August 28, 2024 12:52
@mydea mydea force-pushed the fn/update-action-dep branch from a59c4ab to 77853c1 Compare August 29, 2024 07:35
@mydea
Copy link
Member Author

mydea commented Aug 30, 2024

This seems to be breaking because of this: actions/toolkit#1815 - if/when this is merged & released this should not break anymore 😬

@mydea mydea marked this pull request as draft September 9, 2024 12:57
auto-merge was automatically disabled September 9, 2024 12:57

Pull request was converted to draft

@mydea mydea force-pushed the fn/update-action-dep branch from 01e99f2 to b8a5a29 Compare November 15, 2024 12:46
@mydea mydea marked this pull request as ready for review November 15, 2024 13:12
@mydea
Copy link
Member Author

mydea commented Nov 15, 2024

I updated this, seems to be fine now!

@mydea mydea force-pushed the fn/update-action-dep branch from b8a5a29 to bdb7602 Compare November 18, 2024 08:42
@mydea mydea merged commit 3778ac9 into develop Nov 18, 2024
151 checks passed
@mydea mydea deleted the fn/update-action-dep branch November 18, 2024 09:07
onurtemizkan pushed a commit that referenced this pull request Nov 22, 2024
v1 of this is deprecated, which you can see in each CI run on develop as
of now. Updating this should fix the deprecation.

This _should_ not break stuff for us:
https://www.npmjs.com/package/@actions/artifact#v2---whats-new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants