Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Always transmit trace data to the client #13337

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Aug 13, 2024

Resolves #13303

Copy link
Contributor

github-actions bot commented Aug 13, 2024

size-limit report 📦

Path Size
@sentry/browser 22.5 KB (0%)
@sentry/browser (incl. Tracing) 34.3 KB (0%)
@sentry/browser (incl. Tracing, Replay) 70.52 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.83 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.91 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 87.54 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 89.36 KB (0%)
@sentry/browser (incl. metrics) 26.81 KB (0%)
@sentry/browser (incl. Feedback) 39.47 KB (0%)
@sentry/browser (incl. sendFeedback) 27.13 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.79 KB (0%)
@sentry/react 25.26 KB (0%)
@sentry/react (incl. Tracing) 37.29 KB (0%)
@sentry/vue 26.65 KB (0%)
@sentry/vue (incl. Tracing) 36.14 KB (0%)
@sentry/svelte 22.64 KB (0%)
CDN Bundle 23.73 KB (0%)
CDN Bundle (incl. Tracing) 35.97 KB (0%)
CDN Bundle (incl. Tracing, Replay) 70.36 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.6 KB (0%)
CDN Bundle - uncompressed 69.61 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 106.54 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.05 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.94 KB (0%)
@sentry/nextjs (client) 37.16 KB (+0.04% 🔺)
@sentry/sveltekit (client) 34.9 KB (0%)
@sentry/node 115.61 KB (0%)
@sentry/node - without tracing 90 KB (0%)
@sentry/aws-serverless 99.42 KB (0%)

@lforst lforst marked this pull request as ready for review August 13, 2024 09:12
@lforst lforst requested a review from Lms24 August 13, 2024 09:12
@@ -27,8 +27,6 @@ export function wrapGetStaticPropsWithSentry(
parameterizedRoute,
dataFetchingMethodName: 'getStaticProps',
});

return errorWrappedGetStaticProps.apply(thisArg, args);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was dead code.

@lforst lforst requested a review from s1gr1d August 13, 2024 09:33
@lforst lforst merged commit 043ae7e into develop Aug 13, 2024
98 checks passed
@lforst lforst deleted the lforst-inject-tracing-metadata-twp branch August 13, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Nextjs] Inject meta tags in Tracing-without-Performance-mode
2 participants