Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): Update nextjs-app-dir E2E tests to avoid sending to Sentry #12403

Merged
merged 2 commits into from
Jun 10, 2024
Merged

test(e2e): Update nextjs-app-dir E2E tests to avoid sending to Sentry #12403

merged 2 commits into from
Jun 10, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Jun 7, 2024

Part of #11910

This removes the tests in nextjs-app-dir where we still polled Sentry.

@mydea mydea requested review from lforst, Lms24 and s1gr1d June 7, 2024 09:19
@mydea mydea self-assigned this Jun 7, 2024
Lms24
Lms24 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea mydea merged commit 8b07998 into develop Jun 10, 2024
79 checks passed
@mydea mydea deleted the fn/nextjs-app-dir-e2e-tests branch June 10, 2024 07:13
billyvg pushed a commit that referenced this pull request Jun 10, 2024
@mydea @billyvg
test(e2e): Update nextjs-app-dir E2E tests to avoid sending to Sentry (…
7a36195 
…#12403)

Part of #11910

This removes the tests in nextjs-app-dir where we still polled Sentry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@s1gr1d s1gr1d s1gr1d approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @Lms24 @s1gr1d