meta: Add Changelog entry for 8.6.0 #12272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Gitflow] Merge master into develop
We are safe to change this now.
This PR introduces `Sentry.reactErrorHandler`, which looks like so:
```js
import * as Sentry from '@sentry/react';
import { hydrateRoot } from "react-dom/client";
ReactDOM.hydrateRoot(
document.getElementById("root"),
<React.StrictMode>
<App />
</React.StrictMode>,
{
onUncaughtError: Sentry.reactErrorHandler(),
onCaughtError: Sentry.reactErrorHandler((error, errorInfo) => {
// optional callback if users want custom config.
}),
}
);
```
To validate this change, we add a react 19 e2e test.
To avoid too large payloads, we should only send up to 1000 spans. We actually had two different problems here in browser and node: 1. In browser, we _did_ limit to 1000, but we did so in an unfortunate way, which is to reset the set after 1000 spans. So if a span had 1010 children, only the last 10 would be send. 2. In node, we just sent all spans. I rewrote this to now consistently send the first 1000 spans of a transaction. I decided to keep all spans (no matter the limit) on the internal parent-child map. Due to this this may grow a lot, but we can avoid inconsistent state (e.g. what happens if a span has a parent in the map, but the parent does not have the span as children, ...) All of these should be garbage collected together ideally, so this should be fine hopefully.
This does two main things: 1. Updates node E2E tests to use `fetch` instead of axios 2. Update node E2E tests to avoid sending to Sentry. Instead, we check everywhere via the proxy that the data sent is OK. Part of #11910
Fixes #12217 Make sure `failure_issue_threshold` and `recovery_threshold` get passed in correctly.
This PR adds request data to server-side Sentry events by extracting the request object in our `sentryHandle` request handler. This is in line with our other SDKs and was simply missing from the SvelteKit SDK so far.
This introduces a new method, `metrics.timing()`, which can be used in
two ways:
1. With a numeric value, to simplify creating a distribution metric.
This will default to `second` as unit:
```js
Sentry.metrics.timing('myMetric', 100);
```
2. With a callback, which will wrap the duration of the callback. This
can accept a sync or async callback. It will create an inactive span
around the callback and at the end emit a metric with the duration of
the span in seconds:
```js
const returnValue = Sentry.metrics.timing('myMetric', measureThisFunction);
```
Closes #12215
This PR implements a versioned Sentry carrier as described in #12188. The idea is that SDKs can from now on access their global Sentry instance and thereby no longer overwrite or interfere with potentially other SDKs (e.g. 3rd party libraries, scripts, etc). Internally, SDKs can access their carrier via the `window.__SENTRY__[SDK_VERSION]`. Externally (spotlight, loader script) via `window.__SENTRY__[window.__SENTRY__.version]`. --------- Co-authored-by: Francesco Novy <[email protected]>
Noticed this while looking into #12244, console should be instrumented just fine in the CDN bundle.
Lms24
requested review from
a team,
mydea,
andreiborza and
lforst
and removed request for
a team
Lms24
force-pushed
the
prepare-release/8.6.00
branch
from
104df63 to
033ecc8
Compare
mydea
reviewed
May 29, 2024
Update CHANGELOG.md Co-authored-by: Francesco Novy <[email protected]>
Lms24
force-pushed
the
prepare-release/8.6.00
branch
from
0974c66 to
787a29b
Compare
mydea
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.