fix(feedback): Be consistent about whether screenshot should and can render #11859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
ryan953
commented
May 1, 2024
| ? _findIntegration<FeedbackScreenshotIntegration>( | ||
| 'FeedbackScreenshot', | ||
| getScreenshotIntegration, | ||
| 'feedbackScreenshotIntegration', | ||
| ) | ||
| : undefined, | ||
| ]); | ||
| if (!modalIntegration || (showScreenshot && !screenshotIntegration)) { |
There was a problem hiding this comment.
this line was preventing the modal from rendering on a real mobile device if showScreenshot:true was set.
why?
we asked for screenshots,
but it's not supported, so we didn't load it
and this like says "we expected it to be loaded, but it's not"
fixed now!
billyvg
approved these changes
May 1, 2024
c298lee
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the conditions for loading and rendering the screenshot integration.... also improves the conditions for not rendering it if we're on a mobile device.
options.showScreenshotinstead of the closed-overshowScreenshotbecause the options might have changed for this instance of the widgetoptions.showScreenshot(the desire) withisScreenshotSupported()(the possibility) to set the right expectation