Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nextjs): Add transaction name to scope of server component #11850

Merged
merged 9 commits into from
May 2, 2024
Merged

feat(nextjs): Add transaction name to scope of server component #11850

merged 9 commits into from
May 2, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Apr 30, 2024

ref #11782

@s1gr1d s1gr1d marked this pull request as draft April 30, 2024 08:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 21.64 KB (added)
@sentry/browser (incl. Tracing) 32.68 KB (added)
@sentry/browser (incl. Tracing, Replay) 68.03 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.43 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.07 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.27 KB (added)
@sentry/browser (incl. Feedback) 37.83 KB (added)
@sentry/browser (incl. sendFeedback) 26.43 KB (added)
@sentry/browser (incl. FeedbackAsync) 30.96 KB (added)
@sentry/react 24.33 KB (added)
@sentry/react (incl. Tracing) 35.64 KB (added)
@sentry/vue 25.47 KB (added)
@sentry/vue (incl. Tracing) 34.47 KB (added)
@sentry/svelte 21.77 KB (added)
CDN Bundle 24.02 KB (added)
CDN Bundle (incl. Tracing) 34.05 KB (added)
CDN Bundle (incl. Tracing, Replay) 67.72 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 73.05 KB (added)
CDN Bundle - uncompressed 70.62 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 100.98 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.59 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 224.22 KB (added)
@sentry/nextjs (client) 34.86 KB (added)
@sentry/sveltekit (client) 33.24 KB (added)
@sentry/node 138.47 KB (added)

@mydea
Copy link
Member

mydea commented Apr 30, 2024

Leaving this here for the future: E.g. this trace: https://sentry-javascript-sdks.sentry.io/performance/trace/24883c2fb15b4ea28ce5787afacc577b/ which comes from the canary tests (I think) shows the root cause, I believe. A bunch of "unrelated" (??) component renders are in the same trace, probably clobbering up the transactionName on the isolationScope, I guess... 🤔

@s1gr1d s1gr1d changed the title feat(nextjs): Add transaction name to isolation scope when page or layout feat(nextjs): Add transaction name to isolation scope only when not defined Apr 30, 2024
@s1gr1d s1gr1d marked this pull request as ready for review April 30, 2024 14:23
@s1gr1d s1gr1d changed the title feat(nextjs): Add transaction name to isolation scope only when not defined feat(nextjs): Add transaction name to scope May 2, 2024
@s1gr1d s1gr1d changed the title feat(nextjs): Add transaction name to scope feat(nextjs): Add transaction name to scope of server component May 2, 2024
@s1gr1d s1gr1d enabled auto-merge (squash) May 2, 2024 09:57
@s1gr1d s1gr1d mentioned this pull request May 2, 2024
Merged
@s1gr1d s1gr1d requested a review from mydea May 2, 2024 11:38
@s1gr1d s1gr1d merged commit 85da8cf into develop May 2, 2024
70 checks passed
@s1gr1d s1gr1d deleted the sig/transactionName-page branch May 2, 2024 11:48
s1gr1d added a commit that referenced this pull request May 2, 2024
@s1gr1d
feat(nextjs): Set transaction names on scope for route handlers and g…
08a3b7c 
…eneration functions (#11869)

for server components:
#11850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s1gr1d @mydea