-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(replay): Add "maxCanvasSize" option for replay canvases #11617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyvg
changed the title
wip
feat(replay): Add "maxCanvasSize" option for replay canvases
Apr 15, 2024
billyvg
force-pushed
the
feat-repla-add-max-size-canvas
branch
3 times, most recently
from
April 18, 2024 20:18
77c675d
to
c7c8e3c
Compare
size-limit report 📦
|
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174
billyvg
force-pushed
the
feat-repla-add-max-size-canvas
branch
from
April 19, 2024 14:42
8309386
to
5ba00b3
Compare
c298lee
approved these changes
Apr 19, 2024
mydea
approved these changes
Apr 22, 2024
Closed
billyvg
added a commit
that referenced
this pull request
Apr 22, 2024
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174 Closes #10498 Backport of #11617
mydea
pushed a commit
that referenced
this pull request
Apr 23, 2024
We do not want to allow users to capture super large canvases, enforce a max size limit Requires getsentry/rrweb#174 Closes #10498 Backport of #11617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want to allow users to capture super large canvases, enforce a max size limit
Requires getsentry/rrweb#174
Closes #10498