Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add "maxCanvasSize" option for replay canvases #11617

Merged
merged 8 commits into from
Apr 22, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Apr 15, 2024

We do not want to allow users to capture super large canvases, enforce a max size limit

Requires getsentry/rrweb#174

Closes #10498

@billyvg billyvg changed the title wip feat(replay): Add "maxCanvasSize" option for replay canvases Apr 15, 2024
@billyvg billyvg force-pushed the feat-repla-add-max-size-canvas branch 3 times, most recently from 77c675d to c7c8e3c Compare April 18, 2024 20:18
@billyvg billyvg marked this pull request as ready for review April 19, 2024 13:20
@billyvg billyvg requested review from mydea and c298lee April 19, 2024 13:20
Copy link
Contributor

github-actions bot commented Apr 19, 2024

size-limit report 📦

Path Size
@sentry/browser 21.67 KB (0%)
@sentry/browser (incl. Tracing) 31.4 KB (0%)
@sentry/browser (incl. Tracing, Replay) 66.74 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.15 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.78 KB (+0.3% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.45 KB (+0.02% 🔺)
@sentry/browser (incl. Feedback) 35.25 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.25 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.28 KB (0%)
@sentry/browser (incl. sendFeedback) 26.46 KB (0%)
@sentry/react 24.35 KB (0%)
@sentry/react (incl. Tracing) 34.31 KB (0%)
@sentry/vue 25.2 KB (0%)
@sentry/vue (incl. Tracing) 33.12 KB (0%)
@sentry/svelte 21.79 KB (0%)
CDN Bundle 24.03 KB (0%)
CDN Bundle (incl. Tracing) 32.71 KB (0%)
CDN Bundle (incl. Tracing, Replay) 66.38 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.58 KB (+0.02% 🔺)
CDN Bundle - uncompressed 70.85 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 97.5 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 207.2 KB (+0.02% 🔺)
@sentry/nextjs (client) 33.64 KB (0%)
@sentry/sveltekit (client) 31.9 KB (0%)
@sentry/node 158.85 KB (-0.01% 🔽)

@billyvg billyvg force-pushed the feat-repla-add-max-size-canvas branch from 8309386 to 5ba00b3 Compare April 19, 2024 14:42
@billyvg billyvg merged commit ea717f4 into develop Apr 22, 2024
97 checks passed
@billyvg billyvg deleted the feat-repla-add-max-size-canvas branch April 22, 2024 16:33
@billyvg billyvg mentioned this pull request Apr 22, 2024
billyvg added a commit that referenced this pull request Apr 22, 2024
We do not want to allow users to capture super large canvases, enforce a
max size limit

Requires getsentry/rrweb#174
Closes #10498
Backport of #11617
mydea pushed a commit that referenced this pull request Apr 23, 2024
We do not want to allow users to capture super large canvases, enforce a
max size limit

Requires getsentry/rrweb#174
Closes #10498
Backport of #11617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set maximum resolution limits for canvas recordings
3 participants