Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vercel-edge): Stop using hub #11539

Merged
merged 5 commits into from
Apr 11, 2024
Merged

feat(vercel-edge): Stop using hub #11539

merged 5 commits into from
Apr 11, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Apr 10, 2024 •
edited by Lms24
Loading

Stops using the hub for the async context in the vercel-edge package.

ref #11482

@lforst lforst requested review from mydea and Lms24 April 10, 2024 14:43
Base automatically changed from lforst-get-current-hub-shim-hoist to develop April 10, 2024 14:44
@lforst lforst requested a review from AbhiPrasad April 10, 2024 14:44
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 22.09 KB (0%)
@sentry/browser (incl. Tracing) 31.78 KB (0%)
@sentry/browser (incl. Tracing, Replay) 66.99 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.58 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.83 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.69 KB (0%)
@sentry/browser (incl. Feedback) 35.64 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.65 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 35.66 KB (0%)
@sentry/browser (incl. sendFeedback) 26.89 KB (0%)
@sentry/react 24.78 KB (0%)
@sentry/react (incl. Tracing) 34.7 KB (0%)
@sentry/vue 25.64 KB (0%)
@sentry/vue (incl. Tracing) 33.5 KB (0%)
@sentry/svelte 22.22 KB (0%)
CDN Bundle 24.14 KB (0%)
CDN Bundle (incl. Tracing) 32.76 KB (0%)
CDN Bundle (incl. Tracing, Replay) 66.47 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 80.5 KB (0%)
CDN Bundle - uncompressed 71.84 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 98.11 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 207.5 KB (0%)
@sentry/nextjs (client) 33.88 KB (0%)
@sentry/sveltekit (client) 32.3 KB (0%)
@sentry/node 120.15 KB (0%)

AbhiPrasad
AbhiPrasad approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just realized we have to do this for browser

@lforst lforst merged commit 9d0472b into develop Apr 11, 2024
62 checks passed
@lforst lforst deleted the lforst-rm-hub-from-vercel-edge branch April 11, 2024 05:30
@Lms24 Lms24 mentioned this pull request Apr 11, 2024
Closed
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@lforst @cadesalaberry
feat(vercel-edge): Stop using hub (getsentry#11539)
bdaaf93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@mydea mydea Awaiting requested review from mydea

@Lms24 Lms24 Awaiting requested review from Lms24

Assignees

@lforst lforst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lforst @AbhiPrasad