feat(webvitals): Add profile id, replay id, and user to standalone INP spans #10849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
| @@ -632,6 +633,7 @@ export class Span implements SpanInterface { | |||
| origin: this._attributes[SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN] as SpanOrigin | undefined, | |||
| _metrics_summary: getMetricSummaryJsonForSpan(this), | |||
| measurements: this._attributes[SEMANTIC_ATTRIBUTE_MEASUREMENTS] as Measurements | undefined, | |||
| profile_id: this._attributes[SEMANTIC_ATTRIBUTE_PROFILE_ID] as string | undefined, | |||
There was a problem hiding this comment.
We're putting profile_id as a top level field because relay expects this
AbhiPrasad
reviewed
Feb 29, 2024
| @@ -564,6 +574,9 @@ function registerInpInteractionListener( | |||
| routeName, | |||
| duration, | |||
| parentContext, | |||
| user, | |||
| activeTransaction, | |||
| replay, | |||
There was a problem hiding this comment.
IMO we should pass in the id's here instead of holding references to replay integration/active transaction
There was a problem hiding this comment.
I should be able to update this for replay ID.
For profiles, the profiling integration only attaches the profile id to the active transaction when the transaction finishes. So we don't immediately have access to a profile id when an interaction occurs. Keeping a reference to the transaction seemed like the easiest way to grab the profile id when we're ready to send an INP. Not sure if there is a better solution, but I can think about it if this is a blocker
There was a problem hiding this comment.
ahh I see, yeah let's hold the transaction reference then, np
…com:getsentry/sentry-javascript into egou/v7/profile-replay-and-user-for-inp
edwardgou-sentry
merged commit 3336ff3
into
egou/v7/feat/add-sampling-rate-to-inp-spans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds profile id, replay id, and user to standalone INP spans.
getReplayId().