chore(biome): Add useRegexLiterals rule
#10010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Jan 2, 2024
anonrig
approved these changes
Jan 2, 2024
|
Love it, but there is a conflict. |
Lms24
force-pushed
the
lms/chore-biome-regex-literals
branch
from
27a2272 to
94bc349
Compare
size-limit report 📦
|
anonrig
pushed a commit
that referenced
this pull request
Jan 3, 2024
Add the [useRegexLiterals](https://biomejs.dev/linter/rules/use-regex-literals/) rule to our biome config which will flag unnecessary usage of the `RegExp` constructor where a static regex could be used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the useRegexLiterals rule to our biome config which will flag unnecessary usage of the
RegExpconstructor where a static regex could be used instead.The fix codemod seems to be still quite buggy, as it e.g. can't correctly convert slashes
new RegExp('/my/path')becomes//my/path/instead of/\/my\/path/. However, an incorrect conversion will trigger other warnings, so I'm okay with that for the moment.ref #9960 (in contrast to #10009, this PR doesn't address the RegExp usage problem but it's a nice addition IMO)