Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Fastify v5 #13774

Closed
Xhale1 opened this issue Sep 24, 2024 · 2 comments · Fixed by #13983
Closed

Support Fastify v5 #13774

Xhale1 opened this issue Sep 24, 2024 · 2 comments · Fixed by #13983
Assignees
@onurtemizkan
Labels
Package: node Issues related to the Sentry Node SDK

Comments

@Xhale1
Copy link

Xhale1 commented Sep 24, 2024

Problem Statement

Fastify v5 released recently, it'd be amazing to see Sentry v8 add support!

Solution Brainstorm

Most of the changes in v5 are removing deprecations, it seems little has changed beyond that. A comment in the linked OTEL issue had a good point that Fastify's new diagnostic channel support could be beneficial.
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Sep 24, 2024
@mydea
Copy link
Member

mydea commented Sep 25, 2024

Thank you for opening this issue, we def. want to support this! We'll look into possibly contributing this upstream.

@mydea mydea added the Package: node Issues related to the Sentry Node SDK label Sep 25, 2024
@onurtemizkan onurtemizkan mentioned this issue Oct 2, 2024
Merged
@onurtemizkan onurtemizkan self-assigned this Oct 2, 2024
@onurtemizkan onurtemizkan mentioned this issue Oct 15, 2024
Merged
billyvg pushed a commit that referenced this issue Oct 17, 2024
@onurtemizkan @billyvg
chore(node): Bump @opentelemetry/instrumentation-fastify to 0.40.0 (
f39a1ed 
#13983)

Resolves: #13774 

Fastify v5 is enabled with release:
https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-fastify-v0.40.0
billyvg pushed a commit that referenced this issue Oct 17, 2024
@onurtemizkan @billyvg
chore(node): Bump @opentelemetry/instrumentation-fastify to 0.40.0 (
eab7d93 
#13983)

Resolves: #13774 

Fastify v5 is enabled with release:
https://github.com/open-telemetry/opentelemetry-js-contrib/releases/tag/instrumentation-fastify-v0.40.0
@github-actions GitHub Actions
Copy link
Contributor

A PR closing this issue has just been released 🚀

This issue was referenced by PR #13983, which was included in the 8.35.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onurtemizkan onurtemizkan

Labels
Package: node Issues related to the Sentry Node SDK
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(node): Bump @opentelemetry/instrumentation-fastify to 0.40.0 getsentry/sentry-javascript
3 participants
@mydea @onurtemizkan @Xhale1