Update integration tests

getsentry · Nov 28, 2024 · d58da1c · d58da1c
1 parent 44e1068
commit d58da1c
Show file tree

Hide file tree

Showing 8 changed files with 55 additions and 5 deletions.
diff --git a/dev-packages/browser-integration-tests/suites/integrations/httpclient/axios/test.ts b/dev-packages/browser-integration-tests/suites/integrations/httpclient/axios/test.ts
@@ -40,6 +40,15 @@ sentryTest(
               type: 'http.client',
               handled: false,
             },
+            stacktrace: {
+              frames: expect.arrayContaining([
+                expect.objectContaining({
+                  filename: 'http://sentry-test.io/subject.bundle.js',
+                  function: '?',
+                  in_app: true,
+                }),
+              ]),
+            },
           },
         ],
       },

diff --git a/dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/simple/test.ts b/dev-packages/browser-integration-tests/suites/integrations/httpclient/fetch/simple/test.ts
@@ -42,6 +42,15 @@ sentryTest(
               type: 'http.client',
               handled: false,
             },
+            stacktrace: {
+              frames: expect.arrayContaining([
+                expect.objectContaining({
+                  filename: 'http://sentry-test.io/subject.bundle.js',
+                  function: '?',
+                  in_app: true,
+                }),
+              ]),
+            },
           },
         ],
       },

diff --git a/...ckages/browser-integration-tests/suites/integrations/httpclient/fetch/withRequest/test.ts b/...ckages/browser-integration-tests/suites/integrations/httpclient/fetch/withRequest/test.ts
@@ -38,6 +38,15 @@ sentryTest('works with a Request passed in', async ({ getLocalTestUrl, page }) =
             type: 'http.client',
             handled: false,
           },
+          stacktrace: {
+            frames: expect.arrayContaining([
+              expect.objectContaining({
+                filename: 'http://sentry-test.io/subject.bundle.js',
+                function: '?',
+                in_app: true,
+              }),
+            ]),
+          },
         },
       ],
     },

diff --git a/...tegration-tests/suites/integrations/httpclient/fetch/withRequestAndBodyAndOptions/test.ts b/...tegration-tests/suites/integrations/httpclient/fetch/withRequestAndBodyAndOptions/test.ts
@@ -40,6 +40,15 @@ sentryTest(
               type: 'http.client',
               handled: false,
             },
+            stacktrace: {
+              frames: expect.arrayContaining([
+                expect.objectContaining({
+                  filename: 'http://sentry-test.io/subject.bundle.js',
+                  function: '?',
+                  in_app: true,
+                }),
+              ]),
+            },
           },
         ],
       },

diff --git a/...wser-integration-tests/suites/integrations/httpclient/fetch/withRequestAndOptions/test.ts b/...wser-integration-tests/suites/integrations/httpclient/fetch/withRequestAndOptions/test.ts
@@ -38,6 +38,15 @@ sentryTest('works with a Request (without body) & options passed in', async ({ g
             type: 'http.client',
             handled: false,
           },
+          stacktrace: {
+            frames: expect.arrayContaining([
+              expect.objectContaining({
+                filename: 'http://sentry-test.io/subject.bundle.js',
+                function: '?',
+                in_app: true,
+              }),
+            ]),
+          },
         },
       ],
     },

diff --git a/dev-packages/browser-integration-tests/suites/integrations/httpclient/xhr/test.ts b/dev-packages/browser-integration-tests/suites/integrations/httpclient/xhr/test.ts
@@ -40,6 +40,15 @@ sentryTest(
               type: 'http.client',
               handled: false,
             },
+            stacktrace: {
+              frames: expect.arrayContaining([
+                expect.objectContaining({
+                  filename: 'http://sentry-test.io/subject.bundle.js',
+                  function: '?',
+                  in_app: true,
+                }),
+              ]),
+            },
           },
         ],
       },

diff --git a/dev-packages/browser-integration-tests/utils/generatePlugin.ts b/dev-packages/browser-integration-tests/utils/generatePlugin.ts
@@ -176,7 +176,6 @@ class SentryScenarioGenerationPlugin {
         }
       : {};
 
-    // Checking if the current scenario has imported `@sentry/integrations`.
     compiler.hooks.normalModuleFactory.tap(this._name, factory => {
       factory.hooks.parser.for('javascript/auto').tap(this._name, parser => {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access

diff --git a/packages/browser/src/integrations/httpclient.ts b/packages/browser/src/integrations/httpclient.ts
@@ -46,7 +46,7 @@ const _httpClientIntegration = ((options: Partial<HttpClientOptions> = {}) => {
 
   return {
     name: INTEGRATION_NAME,
-    setup(client: Client): void {
+    setup(client): void {
       _wrapFetch(client, _options);
       _wrapXHR(client, _options);
     },
@@ -93,10 +93,7 @@ function _fetchResponseHandler(
       stacktrace: error instanceof Error ? error.stack : undefined,
     });
 
-    // withScope(scope => {
-    //   scope.setFingerprint([request.url, request.method, response.status.toString()]);
     captureEvent(event);
-    // });
   }
 }