Skip to content

Commit

Permalink
chore(ember): Upgrade Embroider dependencies (#4128)
Browse files Browse the repository at this point in the history
Two old versions were brought in by @sentry/ember
- `0.4.x` was brought in by the very specific, old version of ember-auto-import that the package depends on. It is only able to depend on `1.6.x` releases, which date back to June of 2020
- `0.37.0` was depended on specifically, but the latest is `0.47.1`. Because these are pre-major releases, they will not naturally fluctuate to a newer version

This PR updates both of these dependencies to the latest versions possible without making a breaking change.
  • Loading branch information
alexlafroscia authored and onurtemizkan committed Dec 19, 2021
1 parent 0207695 commit b9bb0c5
Show file tree
Hide file tree
Showing 3 changed files with 384 additions and 359 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
key: ${{ steps.compute_lockfile_hash.outputs.hash }}
- name: Install dependencies
if: steps.cache_dependencies.outputs.cache-hit == ''
run: yarn install
run: yarn install --ignore-engines
outputs:
dependency_cache_key: ${{ steps.compute_lockfile_hash.outputs.hash }}

Expand Down
6 changes: 3 additions & 3 deletions packages/ember/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,19 @@
"test:ember-compatibility": "ember try:each"
},
"dependencies": {
"@embroider/macros": "~0.37.0",
"@embroider/macros": "~0.47.2",
"@sentry/browser": "6.14.3",
"@sentry/tracing": "6.14.3",
"@sentry/types": "6.14.3",
"@sentry/utils": "6.14.3",
"ember-auto-import": "~1.6.0",
"ember-auto-import": "^1.12.0",
"ember-cli-babel": "~7.26.6",
"ember-cli-htmlbars": "^5.7.1",
"ember-cli-typescript": "~3.1.4"
},
"devDependencies": {
"@ember/optional-features": "~1.3.0",
"@embroider/test-setup": "~0.37.0",
"@embroider/test-setup": "~0.47.2",
"@glimmer/component": "~1.0.0",
"@glimmer/tracking": "~1.0.0",
"@sentry-internal/eslint-config-sdk": "6.14.3",
Expand Down
Loading

0 comments on commit b9bb0c5

Please sign in to comment.