fix(apm): Remove Performance references (#2495)

* fix: Calling Performance to not require dom * meta: Changelog * ref: Type
getsentry · Mar 13, 2020 · 13ab8e5 · 13ab8e5
1 parent ef879bf
commit 13ab8e5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott
 
 - [apm] fix: Use Performance API for timings when available, including Web Workers (#2492)
+- [apm] fix: Remove Performance references (#2495)
 
 ## 5.14.1
 

diff --git a/packages/utils/src/misc.ts b/packages/utils/src/misc.ts
@@ -349,7 +349,18 @@ function _htmlElementAsString(el: unknown): string {
 const INITIAL_TIME = Date.now();
 let prevNow = 0;
 
-const performanceFallback: Pick<Performance, 'now' | 'timeOrigin'> = {
+/**
+ * Cross platform compatible partial performance implementation
+ */
+interface CrossPlatformPerformance {
+  /**
+   * Returns the current timestamp in ms
+   */
+  now(): number;
+  timeOrigin: number;
+}
+
+const performanceFallback: CrossPlatformPerformance = {
   now(): number {
     let now = Date.now() - INITIAL_TIME;
     if (now < prevNow) {
@@ -361,10 +372,10 @@ const performanceFallback: Pick<Performance, 'now' | 'timeOrigin'> = {
   timeOrigin: INITIAL_TIME,
 };
 
-export const crossPlatformPerformance: Pick<Performance, 'now' | 'timeOrigin'> = (() => {
+export const crossPlatformPerformance: CrossPlatformPerformance = (() => {
   if (isNodeEnv()) {
     try {
-      const perfHooks = dynamicRequire(module, 'perf_hooks') as { performance: Performance };
+      const perfHooks = dynamicRequire(module, 'perf_hooks') as { performance: CrossPlatformPerformance };
       return perfHooks.performance;
     } catch (_) {
       return performanceFallback;