Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ssl support #944

Merged
merged 6 commits into from
Sep 28, 2020
Merged

feat: ssl support #944

merged 6 commits into from
Sep 28, 2020

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Sep 28, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

feat: ssl support

💡 Motivation and Context

people can pin a self-signed certificate and validate its own hostname, also to resolve #861

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

@marandaneto marandaneto changed the title feat/ssl support feat: ssl support Sep 28, 2020
@marandaneto marandaneto requested a review from a team September 28, 2020 09:19
@marandaneto
Copy link
Contributor Author

continuation of #943

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@77ee2aa). Click here to learn what that means.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #944   +/-   ##
=======================================
  Coverage        ?   71.03%           
  Complexity      ?     1231           
=======================================
  Files           ?      126           
  Lines           ?     4547           
  Branches        ?      461           
=======================================
  Hits            ?     3230           
  Misses          ?     1067           
  Partials        ?      250           
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/sentry/transport/HttpTransport.java 81.13% <66.66%> (ø) 35.00 <0.00> (?)
.../src/main/java/io/sentry/HttpTransportFactory.java 100.00% <100.00%> (ø) 1.00 <0.00> (?)
sentry/src/main/java/io/sentry/SentryOptions.java 79.42% <100.00%> (ø) 78.00 <4.00> (?)
...rc/main/java/io/sentry/hints/SessionStartHint.java 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)
...c/main/java/io/sentry/ShutdownHookIntegration.java 100.00% <0.00%> (ø) 4.00% <0.00%> (?%)
...java/io/sentry/adapters/DateSerializerAdapter.java 42.85% <0.00%> (ø) 2.00% <0.00%> (?%)
sentry/src/main/java/io/sentry/ISentryClient.java 88.88% <0.00%> (ø) 9.00% <0.00%> (?%)
...y/src/main/java/io/sentry/protocol/SdkVersion.java 81.81% <0.00%> (ø) 9.00% <0.00%> (?%)
...ry/src/main/java/io/sentry/DirectoryProcessor.java 68.62% <0.00%> (ø) 7.00% <0.00%> (?%)
... and 119 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ee2aa...6563fb0. Read the comment docs.

@marandaneto
Copy link
Contributor Author

@maciejwalkowiak should we expose then to spring boot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question on unsafe "naive" HostnameVerifier
4 participants