Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CheckInUtils with check-in for a specific environment #3889

Merged
merged 101 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
101 commits
Select commit Hold shift + click to select a range
3fbaf80
Bump reactivecircus/android-emulator-runner from 2.30.1 to 2.31.0 (#3…
dependabot[bot] Jul 2, 2024
25f1ca4
Bump codecov/codecov-action from 4.3.1 to 4.5.0 (#3533)
dependabot[bot] Jul 2, 2024
e34c467
[SR] Session Replay (#3339)
romtsn Jul 15, 2024
2937c11
release: 7.12.0
getsentry-bot Jul 15, 2024
9c4170f
Merge branch 'release/7.12.0'
Jul 15, 2024
a449452
Bump github/codeql-action from 3.25.10 to 3.25.11 (#3529)
dependabot[bot] Jul 16, 2024
028e225
Bump JamesIves/github-pages-deploy-action from 4.5.0 to 4.6.1 (#3531)
dependabot[bot] Jul 16, 2024
83b0c04
Bump gradle/actions (#3532)
dependabot[bot] Jul 16, 2024
7620eac
Add sentry-android-replay module to craft and readme (#3578)
romtsn Jul 16, 2024
73237da
Check app start spans time and foreground state (#3550)
stefanosiano Jul 17, 2024
391c199
release: 7.12.1
getsentry-bot Jul 23, 2024
60865fe
Bump github/codeql-action from 3.25.11 to 3.25.13 (#3591)
dependabot[bot] Jul 23, 2024
485ff61
Bump reactivecircus/android-emulator-runner from 2.31.0 to 2.32.0 (#3…
dependabot[bot] Jul 23, 2024
74ed0f6
Bump JamesIves/github-pages-deploy-action from 4.6.1 to 4.6.3 (#3590)
dependabot[bot] Jul 23, 2024
a0423a0
Bump gradle/actions (#3597)
dependabot[bot] Jul 23, 2024
fc84053
Bump gradle/wrapper-validation-action from 3.4.2 to 3.5.0 (#3589)
dependabot[bot] Jul 23, 2024
7ee0493
Merge branch 'release/7.12.1'
Jul 25, 2024
3a89243
Bump Spring Boot to 3.3.2 (#3541)
adinauer Jul 29, 2024
e039872
[SR] Capture Replays for ANRs and crashes (#3565)
romtsn Jul 30, 2024
b64477e
release: 7.13.0
getsentry-bot Jul 30, 2024
ae2294f
Merge branch 'release/7.13.0'
Jul 31, 2024
7c34b37
Fix lazy select queries instrumentation (#3604)
stefanosiano Aug 1, 2024
09dab51
Avoid ArrayIndexOutOfBoundsException on Android cpu data collection (…
stefanosiano Aug 1, 2024
d4b1f82
[SR] ANR with buffered Replay integration test (#3612)
romtsn Aug 2, 2024
9486895
[SR] Buffer mode improvements (#3622)
romtsn Aug 9, 2024
19d98e8
[SR] Gesture/touch support for Flutter (#3623)
romtsn Aug 9, 2024
32eed6a
Fix app start spans missing from Pixel devices (#3634)
stefanosiano Aug 12, 2024
f6e97b1
[SR] Fix Session Replay crashes (#3628)
romtsn Aug 12, 2024
65295e4
release: 7.14.0
getsentry-bot Aug 12, 2024
9762f09
Merge branch 'release/7.14.0'
Aug 13, 2024
a22aea0
Verify sentry-android-replay for Google Play SDK Console (#3651)
markushi Aug 29, 2024
014dbef
[SR] Rename errorSampleRate to onErrorSampleRate (#3637)
romtsn Sep 3, 2024
70d1da1
Avoid stopping appStartProfiler after application creation (#3630)
stefanosiano Sep 3, 2024
1aaf7d1
Bump JamesIves/github-pages-deploy-action from 4.6.3 to 4.6.4 (#3681)
dependabot[bot] Sep 9, 2024
8586d1f
Bump github/codeql-action from 3.25.13 to 3.26.6 (#3672)
dependabot[bot] Sep 9, 2024
731ae5a
[SR] Detect dominant color for TextViews with Spans (#3682)
romtsn Sep 11, 2024
9e9e16d
Bump github/codeql-action from 3.26.6 to 3.26.7 (#3692)
dependabot[bot] Sep 16, 2024
80d5908
Bump gradle/actions (#3691)
dependabot[bot] Sep 16, 2024
6368d4f
[SR] Add custom redaction options (#3689)
romtsn Sep 16, 2024
61c8d80
Add support for `feedback` envelope header item type (#3687)
denrase Sep 17, 2024
6c8acb8
Bump github/codeql-action from 3.26.7 to 3.26.8 (#3708)
dependabot[bot] Sep 25, 2024
b11dc55
Ensure app context is used even when SDK is initialized via Activity …
markushi Sep 26, 2024
7e57220
Adds breadcrumb origin field (#3727)
antonis Oct 1, 2024
b5b093e
Replace Calendar.getInstance with System.currentTimeMillis for breadc…
romtsn Oct 3, 2024
955c6ee
chore(readme): Add info about updated release channels (#3773)
kahest Oct 8, 2024
503f916
[QA] Lazily load SentryOptions members (#3749)
romtsn Oct 8, 2024
1607621
[QA] Fix potential ANRs due to default integrations (#3778)
markushi Oct 9, 2024
6548825
[SR] Support Jetpack Compose redaction (#3739)
romtsn Oct 9, 2024
0ab3bb3
[SR] Change terminology from redact/ignore to mask/unmask (#3741)
romtsn Oct 9, 2024
f74af4a
release: 7.15.0
getsentry-bot Oct 9, 2024
fe8ba2c
Merge branch 'release/7.15.0'
Oct 9, 2024
f79c9c1
Deprecate `enableTracing` in v7 (#3777)
adinauer Oct 10, 2024
2ab34eb
[QA] Replace SecureRandom with vendored Random (#3783)
romtsn Oct 14, 2024
a9c767e
[QA] Move NDK scope sync to background thread (#3754)
markushi Oct 14, 2024
6259a9f
[QA] Offload System.loadLibrary call to background thread (#3670)
markushi Oct 14, 2024
9c19319
Add meta option to attach ANR thread dumps (#3791)
markushi Oct 14, 2024
8fdee54
fix invalid profiles when the transaction name is empty (#3747)
stefanosiano Oct 15, 2024
274c295
chore: Add action to warn about potentially risky PR changes (#3726)
kahest Oct 15, 2024
654c2dc
Bump reactivecircus/android-emulator-runner from 2.32.0 to 2.33.0 (#3…
dependabot[bot] Oct 16, 2024
55ea3cc
[QA] Make logging faster on startup (#3793)
romtsn Oct 16, 2024
94071da
[QA] Hardcode integration names (#3794)
romtsn Oct 16, 2024
bd82483
Fix ANRv2 test flakyness (#3798)
stefanosiano Oct 16, 2024
ee6ab95
[QA] Make replay lazy and faster (#3799)
romtsn Oct 16, 2024
31f96ce
Bump codecov/codecov-action from 4.5.0 to 4.6.0 (#3768)
dependabot[bot] Oct 17, 2024
2a8b4fe
Bump github/codeql-action from 3.26.8 to 3.26.12 (#3787)
dependabot[bot] Oct 17, 2024
87bdc75
Bump gradle/actions (#3788)
dependabot[bot] Oct 17, 2024
a8c72dd
Fix ensure ndk libs are loaded before calling close (#3797)
markushi Oct 17, 2024
eb5d294
docs(okhttp): update documented default value to match actual (#3800)
marcin-kozinski Oct 17, 2024
143f91a
Bump JamesIves/github-pages-deploy-action from 4.6.4 to 4.6.8 (#3728)
dependabot[bot] Oct 17, 2024
9182d86
[QA] Cache parsed Dsn (#3796)
stefanosiano Oct 17, 2024
f14a299
release: 7.16.0-alpha.1
getsentry-bot Oct 17, 2024
a9b3fbc
Merge branch 'release/7.16.0-alpha.1'
Oct 17, 2024
0132cdd
[QA] Replace setOf with HashSet.add (#3801)
stefanosiano Oct 17, 2024
0cc9262
[QA] Load lazy fields on init in the background (#3803)
stefanosiano Oct 18, 2024
4988d5b
test(ui): Add critical tests run by Maestro (#3802)
krystofwoldrich Oct 21, 2024
28b6ac9
ci(build): Lower gradle workers to max 2 (#3814)
krystofwoldrich Oct 23, 2024
285450b
Prepare Changelog for 7.16.0 release (#3816)
markushi Oct 23, 2024
95f6443
release: 7.16.0
getsentry-bot Oct 23, 2024
7b3de1d
Merge branch 'release/7.16.0'
Oct 23, 2024
378d12c
Bump github/codeql-action from 3.26.12 to 3.26.13 (#3808)
dependabot[bot] Oct 25, 2024
771d13f
Bump androidx test libraries (#3743)
markushi Oct 28, 2024
92ab1d9
Add callout about `addIntegrationToSdkVersion` breaking change (#3829)
romtsn Oct 28, 2024
283c6cc
Accept manifest integer values when requiring floating values (#3823)
stefanosiano Oct 28, 2024
58da2a3
update benchmark devices on saucelabs (#3822)
stefanosiano Oct 28, 2024
4c5d0ff
Bump reactivecircus/android-emulator-runner from 2.32.0 to 2.33.0 (#3…
dependabot[bot] Oct 28, 2024
c362c98
Bump github/codeql-action from 3.26.13 to 3.27.0 (#3827)
dependabot[bot] Oct 28, 2024
5183da9
test(critical): Add API Level matrix (#3810)
krystofwoldrich Oct 28, 2024
28a11a7
Use `Random` through `ThreadLocal<Random>` (#3835)
adinauer Oct 31, 2024
2af8d1a
Fix: Allow MaxBreadcrumb 0 / Expose MaxBreadcrumb metadata. (#3836)
lucas-zimerman Nov 4, 2024
fd1151b
Bump gradle/actions (#3842)
dependabot[bot] Nov 4, 2024
fba10b8
Limit emulator size to 4096M (#3875)
markushi Nov 12, 2024
566da76
Fix standalone tomcat jndi issue (#3873)
lbloder Nov 12, 2024
4bd1aa3
release: 7.17.0
getsentry-bot Nov 12, 2024
cb0ecf1
Merge branch 'release/7.17.0'
Nov 12, 2024
17a41c1
Ensure android initialization process continues even if options confi…
romtsn Nov 13, 2024
091f84e
Add support for 16KB page sizes (Android 15) (#3620)
markushi Nov 14, 2024
a183163
Do not report parsing ANR error when there are no threads (#3888)
romtsn Nov 14, 2024
dab52e2
[QA] Avoid collecting normal frames (#3782)
stefanosiano Nov 14, 2024
05024c4
Extend CheckInUtils with check-in for a specific environment
maxhov Nov 14, 2024
4a98ac5
Merge branch '8.x.x' into checkinutils-environment
adinauer Nov 18, 2024
49624de
changelog
adinauer Nov 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Features

- Allow passing `environment` to `CheckinUtils.withCheckIn` ([3889](https://github.com/getsentry/sentry-java/pull/3889))

## 8.0.0-beta.2

### Breaking Changes
Expand Down
2 changes: 2 additions & 0 deletions sentry/api/sentry.api
Original file line number Diff line number Diff line change
Expand Up @@ -5919,6 +5919,8 @@ public final class io/sentry/util/CheckInUtils {
public fun <init> ()V
public static fun isIgnored (Ljava/util/List;Ljava/lang/String;)Z
public static fun withCheckIn (Ljava/lang/String;Lio/sentry/MonitorConfig;Ljava/util/concurrent/Callable;)Ljava/lang/Object;
public static fun withCheckIn (Ljava/lang/String;Ljava/lang/String;Lio/sentry/MonitorConfig;Ljava/util/concurrent/Callable;)Ljava/lang/Object;
public static fun withCheckIn (Ljava/lang/String;Ljava/lang/String;Ljava/util/concurrent/Callable;)Ljava/lang/Object;
public static fun withCheckIn (Ljava/lang/String;Ljava/util/concurrent/Callable;)Ljava/lang/Object;
}

Expand Down
44 changes: 43 additions & 1 deletion sentry/src/main/java/io/sentry/util/CheckInUtils.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,14 @@ public final class CheckInUtils {
*
* @param monitorSlug - the slug of the monitor
* @param monitorConfig - configuration of the monitor, can be used for upserting schedule
* @param environment - the name of the environment
* @param callable - the {@link Callable} to be called
* @return the return value of the {@link Callable}
* @param <U> - the result type of the {@link Callable}
*/
public static <U> U withCheckIn(
final @NotNull String monitorSlug,
final @Nullable String environment,
final @Nullable MonitorConfig monitorConfig,
final @NotNull Callable<U> callable)
throws Exception {
Expand All @@ -43,6 +45,9 @@ public static <U> U withCheckIn(
if (monitorConfig != null) {
inProgressCheckIn.setMonitorConfig(monitorConfig);
}
if (environment != null) {
inProgressCheckIn.setEnvironment(environment);
}
@Nullable SentryId checkInId = scopes.captureCheckIn(inProgressCheckIn);
try {
return callable.call();
Expand All @@ -52,12 +57,49 @@ public static <U> U withCheckIn(
} finally {
final @NotNull CheckInStatus status = didError ? CheckInStatus.ERROR : CheckInStatus.OK;
CheckIn checkIn = new CheckIn(checkInId, monitorSlug, status);
if (environment != null) {
checkIn.setEnvironment(environment);
}
checkIn.setDuration(DateUtils.millisToSeconds(System.currentTimeMillis() - startTime));
scopes.captureCheckIn(checkIn);
}
}
}

/**
* Helper method to send monitor check-ins for a {@link Callable}
*
* @param monitorSlug - the slug of the monitor
* @param monitorConfig - configuration of the monitor, can be used for upserting schedule
* @param callable - the {@link Callable} to be called
* @return the return value of the {@link Callable}
* @param <U> - the result type of the {@link Callable}
*/
public static <U> U withCheckIn(
final @NotNull String monitorSlug,
final @Nullable MonitorConfig monitorConfig,
final @NotNull Callable<U> callable)
throws Exception {
return withCheckIn(monitorSlug, null, monitorConfig, callable);
}

/**
* Helper method to send monitor check-ins for a {@link Callable}
*
* @param monitorSlug - the slug of the monitor
* @param environment - the name of the environment
* @param callable - the {@link Callable} to be called
* @return the return value of the {@link Callable}
* @param <U> - the result type of the {@link Callable}
*/
public static <U> U withCheckIn(
final @NotNull String monitorSlug,
final @Nullable String environment,
final @NotNull Callable<U> callable)
throws Exception {
return withCheckIn(monitorSlug, environment, null, callable);
}

/**
* Helper method to send monitor check-ins for a {@link Callable}
*
Expand All @@ -68,7 +110,7 @@ public static <U> U withCheckIn(
*/
public static <U> U withCheckIn(
final @NotNull String monitorSlug, final @NotNull Callable<U> callable) throws Exception {
return withCheckIn(monitorSlug, null, callable);
return withCheckIn(monitorSlug, null, null, callable);
}

/** Checks if a check-in for a monitor (CRON) has been ignored. */
Expand Down
40 changes: 40 additions & 0 deletions sentry/src/test/java/io/sentry/util/CheckInUtilsTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,46 @@ class CheckInUtilsTest {
}
}

@Test
fun `sends check-in for wrapped supplier with environment`() {
Mockito.mockStatic(Sentry::class.java).use { sentry ->
val scopes = mock<IScopes>()
val lifecycleToken = mock<ISentryLifecycleToken>()
sentry.`when`<Any> { Sentry.getCurrentScopes() }.thenReturn(scopes)
sentry.`when`<Any> { Sentry.forkedScopes(any()) }.then {
scopes.forkedScopes("test")
}
whenever(scopes.forkedScopes(any())).thenReturn(scopes)
whenever(scopes.makeCurrent()).thenReturn(lifecycleToken)
whenever(scopes.options).thenReturn(SentryOptions())
val returnValue = CheckInUtils.withCheckIn("monitor-1", "environment-1") {
return@withCheckIn "test1"
}

assertEquals("test1", returnValue)
inOrder(scopes, lifecycleToken) {
verify(scopes).forkedScopes(any())
verify(scopes).makeCurrent()
verify(scopes).configureScope(any())
verify(scopes).captureCheckIn(
check {
assertEquals("monitor-1", it.monitorSlug)
assertEquals("environment-1", it.environment)
assertEquals(CheckInStatus.IN_PROGRESS.apiName(), it.status)
}
)
verify(scopes).captureCheckIn(
check {
assertEquals("monitor-1", it.monitorSlug)
assertEquals("environment-1", it.environment)
assertEquals(CheckInStatus.OK.apiName(), it.status)
}
)
verify(lifecycleToken).close()
}
}
}

@Test
fun `sends check-in for wrapped supplier with exception`() {
Mockito.mockStatic(Sentry::class.java).use { sentry ->
Expand Down
Loading