Remove deprecations #3780
Merged
Remove deprecations #3780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d sentry-graphql-core
…ryInstrumentation bean if missing
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
|
adinauer
commented
Oct 9, 2024
| @@ -822,9 +799,6 @@ public static final class Deserializer implements JsonDeserializer<Device> { | |||
| case JsonKeys.ID: | |||
| device.id = reader.nextStringOrNull(); | |||
| break; | |||
| case JsonKeys.LANGUAGE: | |||
There was a problem hiding this comment.
I assume we can also get rid of this. Legacy JSON language should land in unknown.
language has been deprecated for 3 years.
| @@ -232,30 +232,6 @@ public void setIpAddress(final @Nullable String ipAddress) { | |||
| this.ipAddress = ipAddress; | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Can we also get rid of JsonKeys.OTHER here?
There was a problem hiding this comment.
i guess it's fine, as it was deprecated 2 years ago
Performance metrics 🚀
|
stefanosiano
approved these changes
Oct 9, 2024
An error occurred while trying to automatically change base from
feat/remove-enable-tracing
to
8.x.x
October 10, 2024 04:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Remove deprecated APIs etc.
💡 Motivation and Context
Closes #3069
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps