Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metrics #3774

Merged
merged 15 commits into from
Oct 9, 2024
Merged

Remove metrics #3774

merged 15 commits into from
Oct 9, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Oct 8, 2024

📜 Description

Remove metrics API and internal classes.

Metrics will return in the future but we don't know in what form exactly.

💡 Motivation and Context

Closes #3732

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Oct 8, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Remove metrics ([#3774](https://github.com/getsentry/sentry-java/pull/3774))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 4b083a0

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡 nice one! I did a grep on top and couldn't find any remaining leftovers.

Base automatically changed from fix/close-scopes-before-replacing-options to 8.x.x October 9, 2024 08:28
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 411.09 ms 496.54 ms 85.45 ms
Size 1.70 MiB 2.35 MiB 665.37 KiB

Previous results on branch: feat/remove-metrics

Startup times

Revision Plain With Sentry Diff
c6c2c24 442.86 ms 459.00 ms 16.14 ms

App size

Revision Plain With Sentry Diff
c6c2c24 1.70 MiB 2.35 MiB 665.37 KiB

CHANGELOG.md Outdated Show resolved Hide resolved
@adinauer adinauer merged commit 2b34468 into 8.x.x Oct 9, 2024
18 of 20 checks passed
@adinauer adinauer deleted the feat/remove-metrics branch October 9, 2024 11:24
@sysmat
Copy link

sysmat commented Oct 17, 2024

are any alternatives for Sentry.metrics()?

@adinauer
Copy link
Member Author

@sysmat we're still figuring out how it'll work in the future, can't say when we have something to share

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants