Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark trace context @NotNull on Contexts.setTrace #3721

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Sep 26, 2024

📜 Description

💡 Motivation and Context

See #3414 which also mentions inconsistency with iOS SDK.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against cb02c72

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 408.84 ms 412.12 ms 3.29 ms
Size 1.70 MiB 2.35 MiB 668.82 KiB

Previous results on branch: feat/non-nullable-trace-context

Startup times

Revision Plain With Sentry Diff
45ada17 519.35 ms 568.27 ms 48.91 ms
435e37c 437.68 ms 472.53 ms 34.85 ms

App size

Revision Plain With Sentry Diff
45ada17 1.70 MiB 2.35 MiB 668.92 KiB
435e37c 1.70 MiB 2.35 MiB 668.82 KiB

@ghost
Copy link

ghost commented Sep 26, 2024 via email

Base automatically changed from feat/remove-traceheaders-method to 8.x.x September 30, 2024 06:28
An error occurred while trying to automatically change base from feat/remove-traceheaders-method to 8.x.x September 30, 2024 06:28
@adinauer adinauer merged commit 5eb786a into 8.x.x Sep 30, 2024
11 of 21 checks passed
@adinauer adinauer deleted the feat/non-nullable-trace-context branch September 30, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants