-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark trace context @NotNull
on Contexts.setTrace
#3721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
September 26, 2024 03:41
|
Performance metrics 🚀
|
stefanosiano
approved these changes
Sep 26, 2024
Please take for me i understand. If you think better please take for me
thank so much
ในวันที่ พฤ. 26 ก.ย. 2024 16:16 น. Stefano ***@***.***>
เขียนว่า:
… ***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#3721 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BILIGA246TEWI2JAWQ6WXSTZYPGFDAVCNFSM6AAAAABO4CJMWOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZQGYZDCNRUHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
An error occurred while trying to automatically change base from
feat/remove-traceheaders-method
to
8.x.x
September 30, 2024 06:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
💡 Motivation and Context
See #3414 which also mentions inconsistency with iOS SDK.
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps