Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POTEL 45 - Set span origin in ActivityLifecycleIntegration on span options instead of after creating the span / transaction #3702

Merged
merged 9 commits into from
Sep 23, 2024
Merged

POTEL 45 - Set span origin in ActivityLifecycleIntegration on span options instead of after creating the span / transaction #3702

merged 9 commits into from
Sep 23, 2024

Conversation

adinauer
Copy link
Member

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 44722d1

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 417.18 ms 478.31 ms 61.13 ms
Size 1.70 MiB 2.35 MiB 667.12 KiB

Previous results on branch: feat/activity-lifecycle-span-origin

Startup times

Revision Plain With Sentry Diff
a1fc02c 422.73 ms 495.57 ms 72.84 ms

App size

Revision Plain With Sentry Diff
a1fc02c 1.70 MiB 2.35 MiB 667.12 KiB

lbloder
lbloder reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise 👍
Do we need a changelog for this?

Base automatically changed from feat/restore-multi-init-tests to 8.x.x September 23, 2024 12:14
lbloder
lbloder approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@adinauer adinauer merged commit e34b8a2 into 8.x.x Sep 23, 2024
12 of 21 checks passed
@adinauer adinauer deleted the feat/activity-lifecycle-span-origin branch September 23, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbloder lbloder lbloder approved these changes

@romtsn romtsn Awaiting requested review from romtsn

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adinauer @lbloder