Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POTEL 42 - Set init priority for backend integrations #3676

Merged
merged 13 commits into from
Sep 16, 2024
Merged

POTEL 42 - Set init priority for backend integrations #3676

merged 13 commits into from
Sep 16, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Sep 2, 2024 •
edited
Loading

#skip-changelog

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against aeec682

@adinauer adinauer changed the title POTEL 41 - Set init priority for backend integrations POTEL 42 - Set init priority for backend integrations Sep 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 439.74 ms 466.00 ms 26.26 ms
Size 1.70 MiB 2.29 MiB 600.57 KiB

Previous results on branch: feat/potel-42-init-priority-backend

Startup times

Revision Plain With Sentry Diff
fae95aa 442.62 ms 506.82 ms 64.20 ms
b37524d 440.43 ms 495.90 ms 55.47 ms

App size

Revision Plain With Sentry Diff
fae95aa 1.70 MiB 2.29 MiB 600.62 KiB
b37524d 1.70 MiB 2.29 MiB 600.53 KiB

lbloder
lbloder approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/potel-41-set-init-priority-android to 8.x.x September 16, 2024 11:48
An error occurred while trying to automatically change base from feat/potel-41-set-init-priority-android to 8.x.x September 16, 2024 11:48
@adinauer adinauer merged commit 85814d7 into 8.x.x Sep 16, 2024
20 of 21 checks passed
@adinauer adinauer deleted the feat/potel-42-init-priority-backend branch September 16, 2024 12:34
@adinauer adinauer mentioned this pull request Sep 16, 2024
Open
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbloder lbloder lbloder approved these changes

@romtsn romtsn Awaiting requested review from romtsn

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adinauer @lbloder