Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POTEL 41 - Set InitPriority for Android, Manifest option for forceInit #3675

Merged
merged 11 commits into from
Sep 16, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Sep 2, 2024

📜 Description

Set InitPriority for Android, Manifest option for forceInit

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- POTEL 41 - Set InitPriority for Android, Manifest option for forceInit ([#3675](https://github.com/getsentry/sentry-java/pull/3675))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 5745adc

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 406.41 ms 445.76 ms 39.35 ms
Size 1.70 MiB 2.29 MiB 600.58 KiB

Previous results on branch: feat/potel-41-set-init-priority-android

Startup times

Revision Plain With Sentry Diff
8044267 438.44 ms 473.44 ms 35.00 ms
7acee85 401.98 ms 440.58 ms 38.60 ms

App size

Revision Plain With Sentry Diff
8044267 1.70 MiB 2.29 MiB 600.53 KiB
7acee85 1.70 MiB 2.29 MiB 600.58 KiB

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe @stefanosiano, @markushi or @romtsn could also have a quick look

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Base automatically changed from feat/potel-40-init-priorty-settings to 8.x.x September 16, 2024 06:52
@adinauer adinauer merged commit 9b2603b into 8.x.x Sep 16, 2024
17 of 21 checks passed
@adinauer adinauer deleted the feat/potel-41-set-init-priority-android branch September 16, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants