-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POTEL 37d - Bump OpenTelemetry versions #3668
Conversation
# Conflicts: # sentry-opentelemetry/sentry-opentelemetry-core/src/main/java/io/sentry/opentelemetry/SpanDescriptionExtractor.java
…noring sentry specific ones
…PROCESS_COMMAND_ARGS
|
Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Have all instrumentations moved to the new incubating Attributes? Does it actually matter, as the types
and keys
stay the same
I just tested it and the following code shows that it cares about the underlying string, not where the reference is coming from:
I wasn't able to find any usage of the "old" |
📜 Description
Sticking to semconv
1.25.0
as https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/dependencyManagement/build.gradle.kts#L49 hasn't upgraded yet.💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps