Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Add SessionReplayOptions #3283

Merged
merged 11 commits into from
Apr 3, 2024

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Mar 25, 2024

#skip-changelog

📜 Description

  • Introduce SessionReplayOptions which are nested under sentryOptions._experimental
  • Refactor ReplayIntegration to use the options

💡 Motivation and Context

Part of getsentry/sentry#63248

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Mar 25, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 369.82 ms 443.77 ms 73.95 ms
Size 1.70 MiB 2.30 MiB 614.66 KiB

Baseline results on branch: rz/feat/session-replay-integration

Startup times

Revision Plain With Sentry Diff
d7ec9af 353.02 ms 402.46 ms 49.44 ms
223546c 326.56 ms 379.68 ms 53.12 ms
795d513 380.51 ms 445.06 ms 64.55 ms
fac4ae4 432.94 ms 516.76 ms 83.82 ms
2bc4ec3 373.40 ms 450.78 ms 77.38 ms
14060c4 401.53 ms 465.96 ms 64.43 ms
deb27b5 411.48 ms 474.42 ms 62.94 ms
f2b8416 396.36 ms 477.59 ms 81.23 ms
2dc138c 386.16 ms 467.74 ms 81.58 ms

App size

Revision Plain With Sentry Diff
d7ec9af 1.70 MiB 2.30 MiB 614.85 KiB
223546c 1.70 MiB 2.30 MiB 614.27 KiB
795d513 1.70 MiB 2.30 MiB 614.40 KiB
fac4ae4 1.70 MiB 2.30 MiB 614.77 KiB
2bc4ec3 1.70 MiB 2.30 MiB 614.84 KiB
14060c4 1.70 MiB 2.30 MiB 613.83 KiB
deb27b5 1.70 MiB 2.30 MiB 614.54 KiB
f2b8416 1.70 MiB 2.30 MiB 614.88 KiB
2dc138c 1.70 MiB 2.30 MiB 614.27 KiB

Previous results on branch: rz/feat/session-replay-options

Startup times

Revision Plain With Sentry Diff
7966fe7 418.00 ms 524.10 ms 106.10 ms
1afac61 408.40 ms 509.39 ms 100.99 ms
513bf30 336.00 ms 430.32 ms 94.32 ms
baefbb0 380.84 ms 444.04 ms 63.21 ms
431e254 358.90 ms 433.12 ms 74.22 ms
fd6aecc 439.88 ms 511.81 ms 71.94 ms
b6732bf 378.42 ms 454.19 ms 75.77 ms
8569361 386.80 ms 439.91 ms 53.11 ms

App size

Revision Plain With Sentry Diff
7966fe7 1.70 MiB 2.30 MiB 614.46 KiB
1afac61 1.70 MiB 2.30 MiB 614.57 KiB
513bf30 1.70 MiB 2.30 MiB 614.67 KiB
baefbb0 1.70 MiB 2.30 MiB 614.66 KiB
431e254 1.70 MiB 2.30 MiB 614.58 KiB
fd6aecc 1.70 MiB 2.30 MiB 614.65 KiB
b6732bf 1.70 MiB 2.30 MiB 614.31 KiB
8569361 1.70 MiB 2.30 MiB 614.27 KiB

@romtsn romtsn changed the title Add SessionReplayOptions [SR] Add SessionReplayOptions Mar 27, 2024
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just not super happy with your variable naming 😄

Base automatically changed from rz/feat/session-replay-integration to rz/feat/session-replay April 3, 2024 14:53
@romtsn romtsn merged commit 023cb5f into rz/feat/session-replay Apr 3, 2024
22 checks passed
@romtsn romtsn deleted the rz/feat/session-replay-options branch April 3, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants