Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure serialVersionUID of Exception classes are unique #3115

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Ensure serialVersionUID of Exception classes are unique #3115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7375031
Ensure serialVersionUID are unique
markushi Dec 21, 2023
c3f5355
Update changelog
markushi Dec 21, 2023
33b5e5c
Fix api file
markushi Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

- SchedulerFactoryBeanCustomizer now runs first so user customization is not overridden ([#3095](https://github.com/getsentry/sentry-java/pull/3095))
- If you are setting global job listeners please also add `SentryJobListener`
- Ensure serialVersionUID of Exception classes are unique ([#3115](https://github.com/getsentry/sentry-java/pull/3115))

### Dependencies

Expand Down
5 changes: 4 additions & 1 deletion sentry-apollo-3/api/sentry-apollo-3.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@ public final class io/sentry/apollo3/BuildConfig {
}

public final class io/sentry/apollo3/SentryApollo3ClientException : java/lang/Exception {
public static final field Companion Lio/sentry/apollo3/SentryApollo3ClientException$Companion;
public fun <init> (Ljava/lang/String;)V
public final fun getSerialVersionUID ()J
}

public final class io/sentry/apollo3/SentryApollo3ClientException$Companion {
}

public final class io/sentry/apollo3/SentryApollo3HttpInterceptor : com/apollographql/apollo3/network/http/HttpInterceptor {
Expand Down
4 changes: 3 additions & 1 deletion sentry-apollo-3/src/main/java/io/sentry/apollo3/SentryApollo3ClientException.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@ package io.sentry.apollo3
* returns 4xx, 5xx or the `errors` field.
*/
class SentryApollo3ClientException(message: String?) : Exception(message) {
val serialVersionUID = 1L
companion object {
private const val serialVersionUID = 4312120066430858144L
}
}
2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/exception/InvalidSentryTraceHeaderException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
* "sentry-trace" header field.
*/
public final class InvalidSentryTraceHeaderException extends Exception {
private static final long serialVersionUID = 1L;
private static final long serialVersionUID = -8353316997083420940L;
private final @NotNull String sentryTraceHeader;

public InvalidSentryTraceHeaderException(final @NotNull String sentryTraceHeader) {
Expand Down
2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/exception/SentryHttpClientException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* returns 5xx.
*/
public final class SentryHttpClientException extends Exception {
private static final long serialVersionUID = 1L;
private static final long serialVersionUID = 348162238030337390L;

public SentryHttpClientException(final @Nullable String message) {
super(message);
Expand Down