Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Comments cleanup in Scope.java #3060

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

bitsandfoxes
Copy link
Contributor

Sorry. I'm sure this is super helpful.

#skip-changelog

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hacktoberfest is already over, mate

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 388.98 ms 469.39 ms 80.41 ms
Size 1.72 MiB 2.29 MiB 578.09 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4e29063 384.14 ms 447.74 ms 63.60 ms
0bd723b 395.44 ms 472.66 ms 77.22 ms
93a76ca 378.48 ms 451.78 ms 73.30 ms
c7e2fbc 377.85 ms 426.35 ms 48.50 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms
99a51e2 405.11 ms 479.65 ms 74.54 ms
4e29063 364.08 ms 445.51 ms 81.43 ms
2fad834 390.07 ms 470.80 ms 80.73 ms
3d8bd2b 379.45 ms 450.36 ms 70.90 ms
7ca9895 364.31 ms 460.46 ms 96.15 ms

App size

Revision Plain With Sentry Diff
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
99a51e2 1.72 MiB 2.29 MiB 576.34 KiB
4e29063 1.72 MiB 2.29 MiB 578.38 KiB
2fad834 1.72 MiB 2.29 MiB 577.53 KiB
3d8bd2b 1.72 MiB 2.29 MiB 577.53 KiB
7ca9895 1.72 MiB 2.29 MiB 576.51 KiB

@bitsandfoxes bitsandfoxes merged commit b172d4e into main Nov 23, 2023
21 checks passed
@bitsandfoxes bitsandfoxes deleted the bitsandfoxes-patch-1 branch November 23, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants