-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sentry-okhttp module #3005
add sentry-okhttp module #3005
Conversation
Thanks for the PR @ToppleTheNun sorry for the delay here. I quickly tested and looks good on a Spring backend application. Still have to review the PR, but this also needs a review from one of @romtsn @markushi or @stefanosiano so we make sure not to break existing users of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. Leaving the serious part of the review to Android folks.
I'm also happy to point this at the 7.0.0 branch since this could be considered a breaking change. |
3461cc1
to
9105898
Compare
Yeah, I think it's a good idea to make it part of 7.0.0. I will get to this PR a bit later and change whatever is needed, but your initial work is really appreciated, thank you a lot 🙏 We'll make it part of the next |
9105898
to
67a21f4
Compare
partially resolves getsentry#1783
67a21f4
to
1a52a5f
Compare
I updated it to be based correctly on the 7.0.0 branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @ToppleTheNun, great stuff! I've updated the PR with a couple of things:
- Use delegation instead of inheritance, so we don't change the class signature and break binary compatibility
- Update changelog to reflect exactly what changed
- Remove SentryOkHttpUtils from public api as it was exposed by mistake most likely
📜 Description
Add
sentry-okhttp
module, update existing classes insentry-android-okhttp
to use it, and mark existing classes insentry-android-okhttp
as deprecated.💡 Motivation and Context
I use OkHttp in a purely Java project and currently maintain a fork of
sentry-okhttp-android
to enable us to use it, which causes us to miss upstream changes from time to time. This would enable us, and others, to be able to use an official Sentry SDK for instrumenting OkHttp.Closes #1783.
💚 How did you test it?
I use a very similar version to the one in this PR in a project and it works. I also copied the existing tests from
sentry-android-okhttp
over and made sure they passed without changes.📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps