-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SENTRY_AUTO_INIT environment variable to control OpenTelemetry Agent init #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
romtsn,
stefanosiano and
markushi
as code owners
December 2, 2022 10:25
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1e1ab7f | 383.48 ms | 441.37 ms | 57.89 ms |
90e9745 | 314.68 ms | 357.28 ms | 42.60 ms |
81a1a6c | 294.04 ms | 341.19 ms | 47.15 ms |
81a1a6c | 328.73 ms | 421.28 ms | 92.55 ms |
4a9c176 | 320.62 ms | 334.68 ms | 14.06 ms |
3695453 | 314.63 ms | 353.10 ms | 38.47 ms |
a04f788 | 321.78 ms | 354.12 ms | 32.35 ms |
31f3e4c | 325.22 ms | 342.77 ms | 17.55 ms |
ecf9680 | 326.55 ms | 360.26 ms | 33.71 ms |
ecf9680 | 321.55 ms | 385.52 ms | 63.97 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1e1ab7f | 1.73 MiB | 2.32 MiB | 612.36 KiB |
90e9745 | 1.73 MiB | 2.32 MiB | 608.63 KiB |
81a1a6c | 1.73 MiB | 2.32 MiB | 612.47 KiB |
81a1a6c | 1.73 MiB | 2.32 MiB | 612.47 KiB |
4a9c176 | 1.73 MiB | 2.33 MiB | 612.69 KiB |
3695453 | 1.73 MiB | 2.32 MiB | 611.62 KiB |
a04f788 | 1.73 MiB | 2.32 MiB | 609.88 KiB |
31f3e4c | 1.73 MiB | 2.32 MiB | 612.47 KiB |
ecf9680 | 1.73 MiB | 2.32 MiB | 612.39 KiB |
ecf9680 | 1.73 MiB | 2.32 MiB | 612.39 KiB |
Previous results on branch: feat/allow-turning-off-auto-init-in-otel-agent
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fd9d617 | 319.02 ms | 351.73 ms | 32.71 ms |
fe38665 | 278.45 ms | 324.78 ms | 46.33 ms |
10bb0b0 | 305.47 ms | 334.56 ms | 29.09 ms |
961331f | 284.29 ms | 341.83 ms | 57.54 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
fd9d617 | 1.73 MiB | 2.32 MiB | 612.36 KiB |
fe38665 | 1.73 MiB | 2.32 MiB | 612.44 KiB |
10bb0b0 | 1.73 MiB | 2.32 MiB | 612.39 KiB |
961331f | 1.73 MiB | 2.32 MiB | 612.44 KiB |
Codecov ReportBase: 80.03% // Head: 80.03% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2410 +/- ##
=========================================
Coverage 80.03% 80.03%
Complexity 3765 3765
=========================================
Files 301 301
Lines 14207 14207
Branches 1884 1884
=========================================
Hits 11371 11371
Misses 2092 2092
Partials 744 744 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
markushi
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Add SENTRY_AUTO_INIT environment variable to control OpenTelemetry Agent init.
💡 Motivation and Context
If a user provides
SENTRY_DSN
orSENTRY_PROPERTIES_FILE
environment variables but intends to use Sentry.init in the target application this allows them to turn off auto init by the Sentry OpenTelemetry Java Agent.💚 How did you test it?
Manually
📝 Checklist
🔮 Next steps