Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump/native 0.4.17 #2033

Merged
merged 1 commit into from
May 11, 2022
Merged

Bump/native 0.4.17 #2033

merged 1 commit into from
May 11, 2022

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented May 10, 2022

📜 Description

Update the native dependency to the latest version

💡 Motivation and Context

💚 How did you test it?

In the Unity SDK CI: https://github.com/getsentry/sentry-unity/actions/runs/2305224087

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@vaind vaind changed the base branch from main to 6.x.x May 10, 2022 15:09
@vaind vaind force-pushed the bump/native-0.4.17 branch from 24185c7 to 485fe42 Compare May 10, 2022 15:39
@vaind vaind force-pushed the bump/native-0.4.17 branch from 485fe42 to f476d83 Compare May 10, 2022 15:42
@vaind vaind marked this pull request as ready for review May 10, 2022 16:56
@vaind vaind requested review from marandaneto and romtsn as code owners May 10, 2022 16:56
@romtsn
Copy link
Member

romtsn commented May 10, 2022

btw @marandaneto how about we add a sentry-native.version file to the sentry-android-ndk module, where we keep track of the current version? This way it'd be easier to find out what version current HEAD is using. Otherwise one needs to go through the changelog to find out.

@marandaneto
Copy link
Contributor

@romtsn I always check the submodule, a file isn't a bad idea, as long as we don't forget bumping it too ^^
Let's unblock this PR for now tho.

Screenshot 2022-05-11 at 11 05 24

@marandaneto marandaneto merged commit d1c8c4d into 6.x.x May 11, 2022
@marandaneto marandaneto deleted the bump/native-0.4.17 branch May 11, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants