-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include application permissions in Android events #2018
Conversation
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
I'd target every new PR into |
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Outdated
Show resolved
Hide resolved
Once this is done/merged, let's add this to the feature list in the docs https://docs.sentry.io/platforms/android/ |
Codecov Report
@@ Coverage Diff @@
## 6.x.x #2018 +/- ##
=========================================
Coverage 80.79% 80.79%
Complexity 3146 3146
=========================================
Files 228 228
Lines 11645 11645
Branches 1565 1565
=========================================
Hits 9409 9409
Misses 1649 1649
Partials 587 587 Continue to review full report at Codecov.
|
@marandaneto there were no folks from ingest in the TSC, but the general vibe was that it should be part of the app context (since it was designed for those kind of things). Also agreed that it's fine to send it as 2 additional things:
|
📜 Description
App
object of the protocol. For now uses theunknown
field.Some open questions
main
? (would require some changed for theunknown
map)android.permission.CAMERA
) as key for the map or should make it pretty?granted
/not_granted
to something different?💡 Motivation and Context
Closes #1347