-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add locale to device context and deprecate language #1832
Conversation
sentry-android-core/src/test/java/io/sentry/android/core/DefaultAndroidEventProcessorTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment.
Codecov Report
@@ Coverage Diff @@
## main #1832 +/- ##
============================================
- Coverage 75.72% 75.69% -0.03%
Complexity 2194 2194
============================================
Files 218 218
Lines 7806 7810 +4
Branches 828 828
============================================
+ Hits 5911 5912 +1
- Misses 1493 1496 +3
Partials 402 402
Continue to review full report at Codecov.
|
📜 Description
Feat: Add locale to device context and deprecate language
language
now returns only the language egen
instead ofen_US
, since thelanguage
field was never indexed, its not a breaking change on discover and alerts💡 Motivation and Context
language
was actually thelocale
, andlocale
was missing.Closes #1834
💚 How did you test it?
unit tests
📝 Checklist
🔮 Next steps
add Support for https://develop.sentry.dev/sdk/event-payloads/contexts/#culture-context