Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add "data" to spans #1717

Merged
merged 6 commits into from
Sep 15, 2021
Merged

Feat: Add "data" to spans #1717

merged 6 commits into from
Sep 15, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

@maciejwalkowiak maciejwalkowiak commented Sep 15, 2021 •
edited
Loading

📜 Description

Add "data" to spans.

💡 Motivation and Context

Fixes #1233

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review September 15, 2021 08:41
@maciejwalkowiak
Copy link
Contributor Author

Thanks for polishing @marandaneto

@maciejwalkowiak maciejwalkowiak merged commit 28ed730 into main Sep 15, 2021
@maciejwalkowiak maciejwalkowiak deleted the gh-1233 branch September 15, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Span.data is missing
2 participants
@maciejwalkowiak @marandaneto