Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor JSON: SentryThread #1686

Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Aug 30, 2021

#skip-changelog

📜 Description

  • Implement serialization/deserialization for SentryThread
  • Implement serialization/deserialization for SentryStackTrace
  • Implement serialization/deserialization for SentryStackFrame
  • Change JsonUnknownSerializationTest to parameterized test to avoid duplication.

💚 How did you test it?

  • Added tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@denrase denrase self-assigned this Aug 30, 2021
…entry-thread

# Conflicts:
#	sentry/src/test/java/io/sentry/JsonUnknownSerializationTest.kt
@denrase denrase changed the base branch from main to feat/vendor-json-writer-reader August 30, 2021 13:36
@denrase denrase mentioned this pull request Aug 30, 2021
47 tasks
@denrase denrase marked this pull request as ready for review August 30, 2021 13:40
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2021

Codecov Report

Merging #1686 (95f056c) into feat/vendor-json-writer-reader (35923ff) will increase coverage by 1.08%.
The diff coverage is 95.18%.

Impacted file tree graph

@@                         Coverage Diff                          @@
##             feat/vendor-json-writer-reader    #1686      +/-   ##
====================================================================
+ Coverage                             78.29%   79.37%   +1.08%     
- Complexity                             2526     2603      +77     
====================================================================
  Files                                   216      216              
  Lines                                  8786     8971     +185     
  Branches                               1058     1099      +41     
====================================================================
+ Hits                                   6879     7121     +242     
+ Misses                                 1469     1424      -45     
+ Partials                                438      426      -12     
Impacted Files Coverage Δ
...main/java/io/sentry/protocol/SentryStackTrace.java 89.09% <92.50%> (+35.75%) ⬆️
...src/main/java/io/sentry/protocol/SentryThread.java 89.53% <95.00%> (+19.16%) ⬆️
...main/java/io/sentry/protocol/SentryStackFrame.java 83.56% <96.55%> (+48.56%) ⬆️
...y/src/main/java/io/sentry/protocol/DebugImage.java 83.87% <0.00%> (+19.35%) ⬆️
...ntry/src/main/java/io/sentry/protocol/SdkInfo.java 85.71% <0.00%> (+23.21%) ⬆️
...ry/src/main/java/io/sentry/protocol/DebugMeta.java 85.71% <0.00%> (+26.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35923ff...95f056c. Read the comment docs.

@denrase denrase merged commit 9472dfb into feat/vendor-json-writer-reader Aug 31, 2021
@denrase denrase deleted the feat/vendor-json-sentry-thread branch August 31, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants