-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vendor JSON: SentryThread #1686
Merged
denrase
merged 6 commits into
feat/vendor-json-writer-reader
from
feat/vendor-json-sentry-thread
Aug 31, 2021
Merged
Vendor JSON: SentryThread #1686
denrase
merged 6 commits into
feat/vendor-json-writer-reader
from
feat/vendor-json-sentry-thread
Aug 31, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entry-thread # Conflicts: # sentry/src/test/java/io/sentry/JsonUnknownSerializationTest.kt
denrase
requested review from
bruno-garcia,
maciejwalkowiak and
marandaneto
as code owners
August 30, 2021 13:40
Codecov Report
@@ Coverage Diff @@
## feat/vendor-json-writer-reader #1686 +/- ##
====================================================================
+ Coverage 78.29% 79.37% +1.08%
- Complexity 2526 2603 +77
====================================================================
Files 216 216
Lines 8786 8971 +185
Branches 1058 1099 +41
====================================================================
+ Hits 6879 7121 +242
+ Misses 1469 1424 -45
+ Partials 438 426 -12
Continue to review full report at Codecov.
|
marandaneto
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
📜 Description
SentryThread
SentryStackTrace
SentryStackFrame
JsonUnknownSerializationTest
to parameterized test to avoid duplication.💚 How did you test it?
📝 Checklist
🔮 Next steps