Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor JSON Writer/Reader: SentryRuntime #1672

Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Aug 23, 2021

#skip-changelog

📜 Description

  • Implement serialization/deserialization for SentryRuntime

💚 How did you test it?

  • Added tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@denrase denrase self-assigned this Aug 23, 2021
@denrase denrase changed the base branch from main to feat/vendor-json-writer-reader-interfaces August 23, 2021 11:10
@denrase denrase marked this pull request as ready for review August 23, 2021 11:11
@denrase denrase mentioned this pull request Aug 23, 2021
47 tasks
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feat/vendor-json-writer-reader-interfaces@ecc145e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                             Coverage Diff                              @@
##             feat/vendor-json-writer-reader-interfaces    #1672   +/-   ##
============================================================================
  Coverage                                             ?   77.36%           
  Complexity                                           ?     2402           
============================================================================
  Files                                                ?      216           
  Lines                                                ?     8156           
  Branches                                             ?      929           
============================================================================
  Hits                                                 ?     6310           
  Misses                                               ?     1445           
  Partials                                             ?      401           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc145e...457fb0a. Read the comment docs.

Base automatically changed from feat/vendor-json-writer-reader-interfaces to feat/vendor-json-writer-reader August 26, 2021 08:28
…riter-reader-runtime

# Conflicts:
#	sentry/api/sentry.api
#	sentry/src/test/java/io/sentry/JsonUnknownSerializationTest.kt
@denrase denrase merged commit dbd3400 into feat/vendor-json-writer-reader Aug 26, 2021
@denrase denrase deleted the feat/vendor-json-writer-reader-runtime branch August 26, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants