Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Measure app start time #1487

Merged
merged 23 commits into from
Jun 11, 2021
Merged
Prev Previous commit
Next Next commit
comment
marandaneto committed Jun 9, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 4f3001f567042c5e825f630f549aa44e9ad743b0
Original file line number Diff line number Diff line change
@@ -137,7 +137,8 @@ private void startTracing(final @NonNull Activity activity) {
// start transaction with app start timestamp
transaction = hub.startTransaction(activityName, NAV_OP, appStartTime);
// start specific span for app start
// TODO: add description cold/warm
// TODO: add description cold/warm or different operation? how do we break down
// per app start cold/warm?
appStartSpan = transaction.startChild("app.start", appStartTime);
}

2 changes: 1 addition & 1 deletion sentry/src/main/java/io/sentry/Span.java
Original file line number Diff line number Diff line change
@@ -80,7 +80,7 @@ public final class Span implements ISpan {
}

@Override
public @NotNull ISpan startChild(@NotNull String operation, @NotNull Date timestamp) {
public @NotNull ISpan startChild(final @NotNull String operation, final @NotNull Date timestamp) {
return transaction.startChild(context.getSpanId(), operation, timestamp);
}