Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Activity tracing auto instrumentation for Android API < 29 #1402

Merged
merged 6 commits into from
Apr 15, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Apr 14, 2021

📜 Description

Fix: Activity tracing auto instrumentation for Android API < 29

💡 Motivation and Context

#1401

https://developer.android.com/reference/android/app/Application.ActivityLifecycleCallbacks#onActivityPreCreated(android.app.Activity,%20android.os.Bundle)
and https://developer.android.com/reference/android/app/Application.ActivityLifecycleCallbacks#onActivityPostResumed(android.app.Activity) are only available on API >= 29 running on the device, it does not matter if it's been compiled using API target >= 29

💚 How did you test it?

running on API 28 and 29

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto marandaneto merged commit 75a8742 into main Apr 15, 2021
@marandaneto marandaneto deleted the fix/acitvity-auto-inst-api29 branch April 15, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants