Copy options tags to transactions. #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
bruno-garcia and
marandaneto
as code owners
bruno-garcia
approved these changes
Jan 21, 2021
marandaneto
reviewed
Jan 21, 2021
Comment on lines
+403
to
+411
| if (transaction.getTags() == null) { | ||
| transaction.setTags(new HashMap<>(options.getTags())); | ||
| } else { | ||
| for (Map.Entry<String, String> item : options.getTags().entrySet()) { | ||
| if (!transaction.getTags().containsKey(item.getKey())) { | ||
| transaction.setTag(item.getKey(), item.getValue()); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
what's about the tags set on the scope? should we also copy them?
There was a problem hiding this comment.
oof, yeah we're missing that. All tags should be added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Copy options tags to transactions.
💡 Motivation and Context
Fixes #1163
💚 How did you test it?
📝 Checklist
🔮 Next steps
Perhaps tags from the scope (and potentially other properties from the scope) should be applied on transactions too?