-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Spring integration #1188
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1188 +/- ##
============================================
- Coverage 74.70% 74.64% -0.07%
- Complexity 1662 1670 +8
============================================
Files 174 176 +2
Lines 5851 5872 +21
Branches 572 572
============================================
+ Hits 4371 4383 +12
- Misses 1216 1225 +9
Partials 264 264
Continue to review full report at Codecov.
|
don't make Wars make Jars cc @bruno-garcia haha |
📜 Description
Simplify using Sentry error reporting and Sentry Performance feature in Spring (non-boot) integration. Also, change the sample project for Spring integration into traditional WAR application.
💡 Motivation and Context
Sentry Spring integration was working well with embedded servlet containers scenarios but appeared to be difficult to configure when used in traditional WAR deployment.
Also, fixed: #1187
💚 How did you test it?
Unit & Integration tests.
📝 Checklist
🔮 Next steps
Since there is a method
IHub#getOptions
there is a potential to move some bits ofsentry-spring
tosentry-servlet
.