Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SpanContext on SentryTransaction to avoid potential NPE. #1173

Merged
merged 4 commits into from
Jan 18, 2021

Conversation

maciejwalkowiak
Copy link
Contributor

📜 Description

Set trace context on SentryTransaction and pass it to contexts on transaction#finish.

💡 Motivation and Context

The alternative to #1164

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

@maciejwalkowiak
Copy link
Contributor Author

@bruno-garcia @marandaneto I think this is a better than #1164 approach - the result the discussion we had. I think trace context on finish is cleaner than doing it during serialization.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer!

@maciejwalkowiak maciejwalkowiak marked this pull request as ready for review January 18, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants