-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add java doc based on sentry-data-schemes project #1045
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for doing this @Panthaaaa appreciated.
I've written 2 or 3 comments but they are easy fixes, work on them and LGTM.
Co-authored-by: Manoel Aranda Neto <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks a lot for this PR.
It fixed it, but its conflicting with the editorconfig. (So IDEA reverted it on commit, but I think thats why you recommend the commit-hook) |
Codecov Report
@@ Coverage Diff @@
## main #1045 +/- ##
=========================================
Coverage 71.98% 71.98%
Complexity 1322 1322
=========================================
Files 135 135
Lines 4816 4816
Branches 492 492
=========================================
Hits 3467 3467
Misses 1091 1091
Partials 258 258
Continue to review full report at Codecov.
|
📢 Type of change
📜 Description
Added java docs to the protocol classes based on the https://github.com/getsentry/sentry-data-schemas project.
💡 Motivation and Context
It improves accessibility of the SDK because all the important information is directly in the javadoc instead of in someones browser.
💚 How did you test it?
make compile
as I only added java docs.📝 Checklist
🔮 Next steps