Skip to content

Commit

Permalink
Make DebugImagesLoader public (#2993)
Browse files Browse the repository at this point in the history
* DebugImagesLoader is now public, to allow manually init the NDK
  • Loading branch information
stefanosiano authored Oct 17, 2023
1 parent 0f88e95 commit c296b28
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Features

- Make `DebugImagesLoader` public ([#2993](https://github.com/getsentry/sentry-java/pull/2993))

### Fixes

- Set export flag on Android receivers on API 33+ ([#2990](https://github.com/getsentry/sentry-java/pull/2990))
Expand Down
6 changes: 6 additions & 0 deletions sentry-android-ndk/api/sentry-android-ndk.api
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ public final class io/sentry/android/ndk/BuildConfig {
public fun <init> ()V
}

public final class io/sentry/android/ndk/DebugImagesLoader : io/sentry/android/core/IDebugImagesLoader {
public fun <init> (Lio/sentry/android/core/SentryAndroidOptions;Lio/sentry/android/ndk/NativeModuleListLoader;)V
public fun clearDebugImages ()V
public fun loadDebugImages ()Ljava/util/List;
}

public final class io/sentry/android/ndk/NdkScopeObserver : io/sentry/IScopeObserver {
public fun <init> (Lio/sentry/SentryOptions;)V
public fun addBreadcrumb (Lio/sentry/Breadcrumb;)V
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,11 @@
import org.jetbrains.annotations.Nullable;
import org.jetbrains.annotations.VisibleForTesting;

final class DebugImagesLoader implements IDebugImagesLoader {
/**
* Class used for loading the list of debug images from sentry-native. Using this class requires
* manually initializing the SDK.
*/
public final class DebugImagesLoader implements IDebugImagesLoader {

private final @NotNull SentryOptions options;

Expand All @@ -23,7 +27,7 @@ final class DebugImagesLoader implements IDebugImagesLoader {
/** we need to lock it because it could be called from different threads */
private static final @NotNull Object debugImagesLock = new Object();

DebugImagesLoader(
public DebugImagesLoader(
final @NotNull SentryAndroidOptions options,
final @NotNull NativeModuleListLoader moduleListLoader) {
this.options = Objects.requireNonNull(options, "The SentryAndroidOptions is required.");
Expand Down

0 comments on commit c296b28

Please sign in to comment.