Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert “Create modules for integrations (#919)” #942

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

cleptric
Copy link
Member

This is currently causing issues, as even without a new tag on the master branch, these new modules are being picked up as something like github.com/getsentry/sentry-go/fiber v0.0.0-20241230225403-109fca191e09 which breaks current installations.

@cleptric cleptric self-assigned this Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (109fca1) to head (63c47ce).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #942      +/-   ##
==========================================
+ Coverage   83.64%   83.89%   +0.25%     
==========================================
  Files          49       49              
  Lines        5129     5129              
==========================================
+ Hits         4290     4303      +13     
+ Misses        682      671      -11     
+ Partials      157      155       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ribice
Copy link
Collaborator

ribice commented Dec 30, 2024

Are you going to merge these immediately prior to new release (to prevent these issues) or will leave them as they were (i.e. not being independent modules)

@cleptric
Copy link
Member Author

We need to merge this ASAP, and can figure out the problem afterwards.

@cleptric cleptric merged commit 17adca9 into master Dec 30, 2024
15 of 16 checks passed
@cleptric cleptric deleted the revert-modules branch December 30, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants