Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update JavaScript SDKs to v8.48.0 #1046

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jan 7, 2025

Updates JavaScript SDKs to v8.48.0.

The Node SDK has a fix for ANR debug IDs so this PR also includes test changes to confirm this.

@timfish timfish marked this pull request as ready for review January 7, 2025 21:09
@kpujjigit
Copy link

@timfish sounds like this is the PR that will allow ANR events to symbolicate? Would a client on SDK v5.9.0 need to make any changes on their side? Or will it work once this is merged?

Thanks for all you've done!

@timfish
Copy link
Collaborator Author

timfish commented Jan 7, 2025

This needs to be merged and then this will be released in v5.10.0

@@ -55,7 +55,7 @@ jobs:
# we want that the matrix keeps running, default is to cancel all if one fails.
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this changed?

Copy link
Collaborator Author

@timfish timfish Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubuntu-latest changed to Ubuntu 24 in the last week and all the Linux tests started failing due to sandbox issues:
https://github.com/getsentry/sentry-electron/actions/runs/12652009781

The SUID sandbox helper binary was found, but is not configured correctly. Rather than run without sandboxing I'm aborting now. You need to make sure that /home/runner/work/sentry-electron/sentry-electron/.cache/30.5.1-x64/chrome-sandbox is owned by root and has mode 4755.

We already had to disable the sandbox for older versions of Electron but something has changed in the latest Github Actions images

if (process.platform === 'linux' && (version.major || 0) < 13) {
args.push('--no-sandbox');
}

We cannot disable the sandbox entirely on Linux because we need to test it's functionality!

I need to find a way to fix this but it's not important for this PR

@timfish timfish enabled auto-merge (squash) January 8, 2025 09:46
@timfish timfish closed this Jan 8, 2025
auto-merge was automatically disabled January 8, 2025 11:27

Pull request was closed

@timfish timfish reopened this Jan 8, 2025
@timfish
Copy link
Collaborator Author

timfish commented Jan 8, 2025

For some reason CI is reporting:

image

But they have clearly completed sucessfully:

https://github.com/getsentry/sentry-electron/actions/runs/12669658435/job/35307658102?pr=1046

@chargome
Copy link
Member

chargome commented Jan 8, 2025

@timfish yeah we had this kind of issue before, the branch protection rules are looking for "ubuntu-latest" (exactly that name) but the since the image has changed the name is different. @mydea do you have access rights to modify this?

@mydea
Copy link
Member

mydea commented Jan 8, 2025

I updated branch protection to require ubuntu-22.04 instead of ubuntu-latest!

@timfish timfish merged commit 69333d2 into master Jan 8, 2025
67 checks passed
@timfish timfish deleted the feat/javascript-sdks branch January 8, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ANR Events not Symbolicating
4 participants