Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deprecate renderer init options which should only be used in main process #1044

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Jan 1, 2025

In the Electron SDK, most of Sentry configuration occurs on the Electron main process because that is where all envelopes are sent from.

We don't support or test setting dsn, environment and release from renderer processes so this should be more clear from the types.

@timfish timfish requested a review from AbhiPrasad January 2, 2025 11:03
src/renderer/sdk.ts Outdated Show resolved Hide resolved
@timfish timfish requested a review from AbhiPrasad January 2, 2025 21:05
@timfish timfish merged commit 976b580 into master Jan 3, 2025
34 checks passed
@timfish timfish deleted the fix/deprecate-main-process-options branch January 3, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Sentry Electron with Sentry React will cause the environment tag to be missing
2 participants